Favicons don't show up in Firefox Vomnibar

[nsunderland1]

Describe the bug When viewing the current tabs in the Vomnibar in Firefox, favicons don't show up next to the entries.

Behaviour in Firefox:

Expected behaviour (Chrome):

To Reproduce Steps to reproduce the behavior:

1. Open any page in Firefox
2. Press Shift-T to open the list of current tabs in the Vomnibar.
3. The favicon for that tab doesn't appear next to its Vomnibar entry.

This also occurs with other Vomnibar shortcuts (shift-O, shift-B...). Tried on a clean Firefox install with no tweaks to settings or additional addons, no difference.

Browser and Vimium version

Browser: Firefox 80.0.1 OS: Linux 5.4.0-48-generic #52-Ubuntu SMP (Ubuntu 20.04.1 LTS) Vimium version: 1.66

[nsunderland1]

I see this is by design:

https://github.com/philc/vimium/blob/bdf654aebe6f570f427c5f7bc9592cad86e642b5/background_scripts/completion.js#L62-L63

In #2878 the decision was made to use the Google favicon resolver to implement this feature. I can't find much information about the Google favicon resolver, but the article cited in that PR provides a way of using it in browsers other than Chrome using http://www.google.com/s2/favicons?domain_url=[url]. This seems to give mixed results in Firefox:

Obviously it won't work for about: pages, not sure what the issue with Github here is though.

[kiuKisas]

Can we just load the favicon with ${base_url}/favicon.ico ? As it suppose to be there.. EDIT: firefox bug issue regarding access to favicon for reference: https://bugzilla.mozilla.org/show_bug.cgi?id=1315616

[tommyalatalo]

Any progress on this? Just found this today.

[eramdam]

Any progress on this? It looks like the TabSearch addon can load favicons just fine and they seem to use the faviconUrl returned by the browser.tabs.query API

[gdh1995]

The favIconUrl is a nightmare: they're so long that it affects loading time of Vomnibar if Vimium tells Firefox to read, send, insert, parse and show it - https://github.com/gdh1995/vimium-c/issues/365#issuecomment-873785756