search

philc / vimium

The hacker's browser.
https://chrome.google.com/webstore/detail/vimium/dbepggeogbaibhgnhhndojpepiihcmeb
MIT License
23.37k stars 2.48k forks source link

duplicate characters in the link hint character settings are not warned about or prevented #3714

Open lahwran opened 3 years ago

lahwran commented 3 years ago

Describe the bug pressing f shows the link hints and most of them work fine but for some reason any link hint that ends in g is duplicated and trying to use it results in this weird state where it doesn't seem to be possible to disambiguate them with any key. this always happens with g and never happens with anything else as far as i'm aware. it also happens with link hints ag and bg.

To Reproduce Steps to reproduce the behavior:

  1. Go to any URL, such as this one
  2. press f: image
  3. press g: image

Browser and Vimium version

chrome version information:

87.0.4280.66 (Official Build) (64-bit) (cohort: 87_66_Win)
--
Revision | fd98a29dd59b36f71e4741332c9ad5bda42094bf-refs/branch-heads/4280@{#1432}
OS | Windows 10 OS Version 2009 (Build 19042.630)

vimium version information:

1.66
installed from https://chrome.google.com/webstore/detail/vimium/dbepggeogbaibhgnhhndojpepiihcmeb
lahwran commented 3 years ago

by reading https://github.com/philc/vimium/blob/master/content_scripts/link_hints.js, i discovered there is a setting controlling what keys to use, and so i went and found that setting in the settings page and what do you know, i had a 'g' appended to it, probably from trying to figure out how to use the extension while on the extension settings page initially. that reduces the severity of this bug report somewhat, it still should probably be de- duplicating characters from that setting but is less of a big deal if i can just change that setting to fix it.