philc / vimium

The hacker's browser.
https://chrome.google.com/webstore/detail/vimium/dbepggeogbaibhgnhhndojpepiihcmeb
MIT License
23.57k stars 2.49k forks source link

Search "f" broke in chrome on most sites (tags below page instead of on top of the page) #3827

Open DalderupMaurice opened 3 years ago

DalderupMaurice commented 3 years ago

Describe the bug Since today I've noticed that the "f" search doesn't work while using chrome on:

For the 2 sites above, the tags are visually below the page as seen in the screenshot/gif: image

image

Although they still do work when pressed, you cannot see what letters you have to type for what link because the results are BELOW the page instead on top of it.

It does still work on the youtube homepage, but when I press "f" while watching a video it suddenly puts the youtube video in full screen mode instead of searching (never had this before? Not sure why the behavior changed)

To Reproduce Steps to reproduce the behavior:

  1. Type anything into google or visit ANY page on github.com and press F

Browser and Vimium version

Google Chrome 90.0.4430.212 (Officiële build) (64-bits) (cohort: Stable)
Revisie e3cd97fc771b893b7fd1879196d1215b622c2bed-refs/branch-heads/4430@{#1429}
Besturingssysteem Windows 10 OS Version 2009 (Build 19042.985)
JavaScript V8 9.0.257.29

Vimium Version 1.66

Side note - I've been using Vimium for at least 5 years every single day, never had issues until today. (just to show that the issue was never here and something changed to cause the issue)

DalderupMaurice commented 3 years ago

note** I've tried this on my MacBook and it shows the same behavior. Google pages and github display the letters BELOW the whole page.

I also tried this on a windows laptop(windows version 19042.870) with an older chrome version (74.0.3729.108) and there everything works fine.

All 3 devices use my google account and thus settings/vimium version is synced/the same on all of them.

gdh1995 commented 3 years ago

puts the youtube video in full screen mode

This means Youtube grabbed the F key and decided to enter full screen.

====

Have your changed Vimum's styles (in the advanced option of CSS for Vimium UI) ? Or does this issue happen when GitHub is in light mode ?

DalderupMaurice commented 3 years ago

puts the youtube video in full screen mode

This means Youtube grabbed the F key and decided to enter full screen.

====

Have your changed Vimum's styles (in the advanced option of CSS for Vimium UI) ? Or does this issue happen when GitHub is in light mode ?

Pressing F on youtube while on a video also never made it fullscreen until today, but I guess that's another issue :P

That said, to answer your question: I did not change any options inside of Vimium and I get the issue on all 3 themes on Github. The fact that it does the same thing on a Google search page tells me it's not a GH specific issue (I guess).

I did not change any setting, did not add any other plugins I just shut my PC down, went to bed, got up and suddenly this happens 😄

This is what is currently in my CSS field (the same CSS is found on my other windows laptop where the issue doesn't exist):

div > .vimiumHintMarker {
/* linkhint boxes */
background: -webkit-gradient(linear, left top, left bottom, color-stop(0%,#FFF785),
  color-stop(100%,#FFC542));
border: 1px solid #E3BE23;
}

div > .vimiumHintMarker span {
/* linkhint text */
color: black;
font-weight: bold;
font-size: 12px;
}

div > .vimiumHintMarker > .matchingCharacter {
}

And I also removed and reinstalled the plugin several times, but that did not help either.

Btw thanks for the quick reply! 😄

gdh1995 commented 3 years ago

Usually a breaking issue happens when chrome gets upgraded. But recently chrome should have been 91, while I've tested on it but cannot reproduce this issue on Win10. Have you installed some other extensions to control (override) website themes?  or, any on chrome://flags ?

---Original--- From: "Maurice @.> Date: Mon, May 31, 2021 21:29 PM To: @.>; Cc: "Dahan @.**@.>; Subject: Re: [philc/vimium] Search "f" broke in chrome on most sites (tags below page instead of on top of the page) (#3827)

puts the youtube video in full screen mode

This means Youtube grabbed the F key and decided to enter full screen.

====

Have your changed Vimum's styles (in the advanced option of CSS for Vimium UI) ? Or does this issue happen when GitHub is in light mode ?

Pressing F on youtube while on a video also never made it fullscreen until today, but I guess that's another issue :P

That said, to answer your question: I did not change any options inside of Vimium and I get the issue on all 3 themes on Github. The fact that it does the same thing on a Google search page tells me it's not a GH specific issue (I guess).

I did not change any setting, did not add any other plugins I just shut my PC down, went to bed, got up and suddenly this happens 😄

This is what is currently in my CSS field (the same CSS is found on my other windows laptop where the issue doesn't exist): div > .vimiumHintMarker { / linkhint boxes / background: -webkit-gradient(linear, left top, left bottom, color-stop(0%,#FFF785), color-stop(100%,#FFC542)); border: 1px solid #E3BE23; } div > .vimiumHintMarker span { / linkhint text / color: black; font-weight: bold; font-size: 12px; } div > .vimiumHintMarker > .matchingCharacter { }
And I also removed and reinstalled the plugin several times, but that did not help either.

Btw thanks for the quick reply! 😄

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

DalderupMaurice commented 3 years ago

Upon your comment, I disabled ALL my extensions and tried every single one of them in conjunction with Vimium. I discovered that disabling the plugin Karma - Your New Shopping Assistant resolved the issue.

Probably an update propagated to my system which caused the issue. I can hereby state that the issue is resolved upon disabling this extension and this issue can be closed as it is not related to Vimium :)

Thanks again for your quick replies and sorry for the inconvenience!

gdh1995 commented 3 years ago

Yes. This extensions injects some CSS which influences Vimium.

The key code is:

body~div:not(#gdx-bubble-host) {
  position: absolute !important;
  z-index: 100000 !important;
}
gdh1995 commented 3 years ago

Add this to CSS for Vimium UI may help

body~div#vimiumHintMarkerContainer.vimiumReset {
  position: static !important;
}
DalderupMaurice commented 3 years ago

Add this to CSS for Vimium UI may help

body~div#vimiumHintMarkerContainer.vimiumReset {
  position: static !important;
}

Thanks! That got the job done :)

ghost commented 3 years ago

I can confirm that this issue exists on macOS and when a shopping browser extension in enabled. I had downloaded Lolli browser extension this morning and shift +f did not work as expected. I then turned off "Lolli" extension and shift+f now works as expected.

macOS Big Sur v11.1 Brave: Version 1.25.68 Chromium: 91.0.4472.77 (Official Build) (x86_64)