search

philc / vimium

The hacker's browser.
https://chrome.google.com/webstore/detail/vimium/dbepggeogbaibhgnhhndojpepiihcmeb
MIT License
23.16k stars 2.48k forks source link

Firefox: some website links trigger the popup blocker #3945

Open ngoonee opened 2 years ago

ngoonee commented 2 years ago

Describe the bug When using vimium, there are 'some' websites which trigger the popup blocker. I'm providing all the information I have here, but don't have the knowledge to differentiate what's special about this site in particular.

For clarity, the website in question is a Malaysian website which allows you to earn some cash out of the referral rewards given when purchasing at online retail sites. Accounts are free but require some personally-identifying information. I can provide a dummy account if that would help (so as not to unfairly require anything of anyone else).

To Reproduce Steps to reproduce the behavior:

  1. Go to URL https://www.shopback.my/survey-wall
  2. Click on 'Shop Now'
  3. An internal 'pop-up' (within the page) shows up with some marketing material and a link saying "go to survey wall now"
  4. Select the link (either with f or F, no difference)
  5. Opening the new page is blocked by Firefox
  6. Clicking the link with the mouse (left or middle click) both open the page in a new tab without the popup warning.

Browser and Vimium version

This behaviour is not new. These are my current versions, running on Arch Linux.

Firefox 93.0 Vimium 1.67

Additional

I have seen https://github.com/philc/vimium/issues/3539 but using Ctrl while selecting the link doesn't help.

gdh1995 commented 2 years ago

it's a limitation of Firefox, and extensions are not allowed to skip this blocker.

Although there are some tricks for it, according to what you said, it seems that the page uses non-standard way to open a URL, which makes Vimium's trick not work.

---Original--- From: "Ng @.> Date: Wed, Oct 27, 2021 11:21 AM To: @.>; Cc: @.***>; Subject: [philc/vimium] Firefox: some website links trigger the popup blocker(Issue #3945)

Describe the bug When using vimium, there are 'some' websites which trigger the popup blocker. I'm providing all the information I have here, but don't have the knowledge to differentiate what's special about this site in particular.

For clarity, the website in question is a Malaysian website which allows you to earn some cash out of the referral rewards given when purchasing at online retail sites. Accounts are free but require some personally-identifying information. I can provide a dummy account if that would help (so as not to unfairly require anything of anyone else).

To Reproduce Steps to reproduce the behavior:

Go to URL https://www.shopback.my/survey-wall

Click on 'Shop Now'

An internal 'pop-up' (within the page) shows up with some marketing material and a link saying "go to survey wall now"

Select the link (either with f or F, no difference)

Opening the new page is blocked by Firefox

Clicking the link with the mouse (left or middle click) both open the page in a new tab without the popup warning.

Browser and Vimium version

This behaviour is not new. These are my current versions

Firefox 93.0 Vimium 1.67

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

ngoonee commented 2 years ago

it's a limitation of Firefox, and extensions are not allowed to skip this blocker. Although there are some tricks for it, according to what you said, it seems that the page uses non-standard way to open a URL, which makes Vimium's trick not work.

Thanks, so its really something on the page that can't be avoided? It doesn't trigger on mouse click though.

gdh1995 commented 2 years ago

 Well, I'm not sure. So I'll take a try in days.

---Original--- From: "Ng @.> Date: Wed, Oct 27, 2021 11:41 AM To: @.>; Cc: "Dahan @.**@.>; Subject: Re: [philc/vimium] Firefox: some website links trigger the popupblocker (Issue #3945)

it's a limitation of Firefox, and extensions are not allowed to skip this blocker. Although there are some tricks for it, according to what you said, it seems that the page uses non-standard way to open a URL, which makes Vimium's trick not work.

Thanks, so its really something on the page that can't be avoided? It doesn't trigger on mouse click though.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.