search

philc / vimium

The hacker's browser.
https://chrome.google.com/webstore/detail/vimium/dbepggeogbaibhgnhhndojpepiihcmeb
MIT License
23.46k stars 2.49k forks source link

Options not saving on Firefox #4013

Open ccaprani opened 2 years ago

ccaprani commented 2 years ago

Describe the bug The Vimium options are not saving. Pressing Ctrl-Enter, or clicking Save Changes does nothing.

To Reproduce Steps to reproduce the behavior:

  1. Go to URL you want to exclude (e.g. jupyter-lab, so http://localhost:8889)
  2. Click on the Vimium icon
  3. Click 'Add Rule'
  4. EIther leave keys empty or type star
  5. Click Save Changes or typing Ctrl-Enter does nothing.

Alterantively, attempting to do this from the options page is also unsuccessful (see screenshot) - the boxes don't even appear to enter a URL and key.

image

Vimium: 1.67.1

Firefox 97.0 20220202182137 canonical Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:97.0) Gecko/20100101 Firefox/97.0 Linux 5.13.0-28-generic #31-Ubuntu SMP Thu Jan 13 17:41:06 UTC 2022 Yaru-dark / Yaru

gdh1995 commented 2 years ago

Please view the Console of developer tools to see what's wrong on your Vimium and Firefox.

ccaprani commented 2 years ago

Thanks @gdh1995 - what commands should I execute to see what's wrong? I have no idea unfortunately!

gdh1995 commented 2 years ago

According to your snapshot, the Vimium Options page was completely broken and hadn't finished its initialization. So, I think you may open Vimium Options again and see its Console messages.

If Vimium Options initializes successfully, then the bottom left button should have text like Show Advanced Options. image

If there's no error messages on Console. Please open about:debugging#/runtime/this-firefox manually, and click Inspect in the card of Vimium, to see the error log of Vimium's background page: image

ccaprani commented 2 years ago

Thank you again @gdh1995 ! Having restarted Firefox since, the problem has disappeared. It frequently recurs though, so I will report back.

ccaprani commented 2 years ago

Hi @gdh1995 It happened again, so I caught the error - bgSettings is not defined.

I hope it helps!

image

gdh1995 commented 2 years ago

Then you may refresh the Vimium Options page, and I think it will work well.

gdh1995 commented 2 years ago

Oh maybe what I guess is wrong.

I once thought you opened Vimium Options immediately when Firefox starts, so the background page (bgSettings) was not ready yet.

But, according to the snapshot, you had used Vomnibar before visiting Vimium Options, hadn't you?

ccaprani commented 2 years ago

Ah, so VImium Options was a persistant open tab and so opened with FF after last reboot. And yes, used Vimium commands indeed upon open and before checking settings page.

Perhaps the lesson here is Vimium Options is not to be a tab that is left open to avoid reopening on FF startup? Is this a bug?

Refresh doesn't help: image

gdh1995 commented 2 years ago

Because Refresh doesn't help, I think there may be some other errors in Vimium's background page - if the background page works well, then refreshing the whole tab should be able to get a valid bgSettings.

Could you follow https://github.com/philc/vimium/issues/4013#issuecomment-1051657271 and paste the console messages of Vimium's background page here?