search

philc / vimium

The hacker's browser.
https://chrome.google.com/webstore/detail/vimium/dbepggeogbaibhgnhhndojpepiihcmeb
MIT License
22.63k stars 2.45k forks source link

Tab no longer opens completions for custom search engines #4344

Open smblott-github opened 8 months ago

smblott-github commented 8 months ago

Describe the bug

Assume a custom search engine (CSE).

Previously, immediately after opening the vomnibar with a CSE, <Tab> would expand the vomnibar with the most-recent searches on that search engine. This made it super easy to repeat (or edit) a recent search.

This no longer works.

To Reproduce

g: http://www.google.com/search?q=%s Google

and

map sg Vomnibar.activate keyword=g

To replicate... sg, then in (empty) vomnibar <Tab>.

Nothing happens.

The vomnibar would previously have been populated with previous Google searches.

Browser and Vimium version

117.0.5938.157 Vimium 2.0.4

philc commented 8 months ago

Hey @smblott-github, this specific functionality was dropped as part of a recent Vomnibar refactor to migrate its functionality to the manifest v3 APIs. See the description in PR #4292. The specific commit where this was removed was probably fdd02280f4a6b32786a864295855e40520e00151.

I made this change because I thought the code complexity was not worth the feature's utility.

I'll leave this issue open for a few months so you and others can chime in with thoughts.

MarcoLucidi01 commented 8 months ago

i noticed this too and i also don't get (history) completion for CSE anymore which i used all the times for reddit. i have a CSE like this:

r: https://old.reddit.com/r/%s Reddit

before the update, i used to hit O, r, <space>, then start typing e.g. pro, hit <tab>, <enter> and i was on https://old.reddit.com/r/programming/. now i have to type the full subreddit name each time (in this case programming).

Dim0N22 commented 8 months ago

I use this feature extensively. It stopped working in Firefox after a recent update, so I rolled back to 1.67.7 and disabled updates for now. It would be super cool to support it in v2, though v1 works fine in Firefox and hopefully won't break soon.

asmundh commented 8 months ago

My usage matches @MarcoLucidi01 and I use it all the time. Having autocomplete allows me to have fewer "less strict" CSEs. I often use it to navigate to AWS/GitHub resources whose names can be >30 characters.

I have also downgraded to 1.67.7 to compensate.

smblott-github commented 8 months ago

Your call, of course, @philc, but I really miss this.

MarcoLucidi01 commented 3 months ago

any news on this? in the meantime i'm stuck at 1.67.7 :/