search

philc / vimium

The hacker's browser.
https://chrome.google.com/webstore/detail/vimium/dbepggeogbaibhgnhhndojpepiihcmeb
MIT License
23.12k stars 2.48k forks source link

Add display style attribute to prevent popover content from being hidden on GitHub Enterprise (and maybe other sites) #4451

Closed bent0b0x closed 6 months ago

bent0b0x commented 6 months ago

Description

This PR was spun out of this issue, where it was reported that hint markers were no longer visible on GitHub Enterprise pages since this commit.

It looks like GHE pages have some styling rules that prevent popovers that are not technically "open" from being displayed. If we explicitly set our marker container's display style attribute that will take priority over those rules.

Verification

Testing locally, the issue is resolved on GHE

ghewin

I was not able to run the tests locally; it looks like there are some restrictions on my machine that interfere with puppeteer's installation:

error trying to connect: invalid peer certificate: UnknownIssuer

soldonii commented 6 months ago

I'm really looking forward to this PR be approved. Facing same issue using github enterprise. Great PR 👍🏻

philc commented 6 months ago

Thank you @bent0b0x for the diagnosis and fix!

printercu commented 6 months ago

If anybody is looking for a temporary fix, add this to styles in vimium config

 #vimiumHintMarkerContainer {
   display: block;
 }