philc / vimium

The hacker's browser.
https://chrome.google.com/webstore/detail/vimium/dbepggeogbaibhgnhhndojpepiihcmeb
MIT License
22.59k stars 2.45k forks source link

Some nested link anchors inside inline SVG aren't assigned key after pressing `f` #4475

Open SethFalco opened 1 month ago

SethFalco commented 1 month ago

Describe the bug

Some link anchors nested inside an inline SVG do not get picked up as interactable after pressing f.

I have tried to investigate why this is, and if I've done anything wrong here, but I can't find what is exactly going wrong. I have noticed that an error is logged to the console if I hit f when I have the standalone SVG opened in the browser, if that helps.

To Reproduce

Steps to reproduce the behavior:

  1. Go to URL https://svgo.dev/
  2. Scroll down to the Integrations section, which features two clickable items in the SVG.
  3. Press f
  4. Observe, the Docusuaurs logo has a key associated with it, but the PostCSS logo does not.

The following image showcases the website with tab order displayed. You can see that that Vimium has associated a key with all interactable elements on the screen except one, the PostCSS logo:

The following is the standalone SVG, an error appears in the console when I open the local file in the browser and hit f:

svgo_integrations

TypeError: MutationObserver.observe: Argument 1 is not an object.

— ui_component.js:124:14

Browser:

Name    Firefox
Version     126.0
Build ID    20240509170740
Distribution ID     mozilla-flatpak
Update Channel  release

Vimium:

Version 2.1.2
Last Updated 4 April 2024