search

philc / vimium

The hacker's browser.
https://chrome.google.com/webstore/detail/vimium/dbepggeogbaibhgnhhndojpepiihcmeb
MIT License
22.59k stars 2.45k forks source link

Find not scrolling to plaintext results inside div with scrollbar. #4498

Open Jack-023 opened 2 weeks ago

Jack-023 commented 2 weeks ago

Describe the bug

When using find and hitting enter. Vimium is correctly finding results in the page but won't scroll the div down so that they are visible. The search will scroll as expected to results that are links. To Reproduce

Steps to reproduce the behavior:

  1. Go to URL GDScript Reference
  2. Search the page for the string "for" ie /for
  3. Hit n several times. You will see that while it scrolls through the results there will be no feedback at all until it reaches part of a link at which point the page will scroll in the expected way.

Include a screenshot if applicable.

Browser and Vimium version Firefox 127.0 Vimium 2.1.2

UncleSnail commented 1 week ago

Good finding, I am experiencing the same thing on that website. It appears to be an issue with the overflow element being positioned with position: absolute;. If I remove the absolute positioning the scrolling works correctly. Someone should definitely look into this and see if we can find a fix. I think that it scrolls once we reach a link because the link gets put into focus, so the browser automatically scrolls to it, so the difference between plain text and link scrolling working is probably a red herring.

Jack-023 commented 1 week ago

Thanks for your response. Good find on the style that seems to cause the issue. Would be nice to have this fixed but in the meantime I have been able to band-aid the problem by adding a stylus rule to set that property to static on the site.