Does not work on Google search result page

philc / vimium

The hacker's browser.

https://chrome.google.com/webstore/detail/vimium/dbepggeogbaibhgnhhndojpepiihcmeb

MIT License

23.2k stars 2.48k forks source link

Does not work on Google search result page #797

Closed jhshi closed 10 years ago

jhshi commented 11 years ago

Use Alt+D to focus address bar, enter keyword, but the Vimium will refuse working on the result page. Only "x" works though, other keys (f,d,u) don't work.

I've turn the instant search feature off, still not working.

dpzmick commented 11 years ago

It seems to be working again for me. I am using Chromium Version 25.0.1364.160 (186726) from here: http://www.freesmug.org/chromium

jhshi commented 11 years ago

I found that this will only happen when I do the search using Omnibox. When I use Google's homepage to search, then it's fine. I guess some URL option in Omnibox's default search engine is the cause. Please see my blog post for more details. http://jhshi.me/2013/03/15/vimium-not-working-in-google-search-results-page/

bkanuka commented 11 years ago

jhshi might also have the "solution". The Vimium extension could also just set a new default search engine.

Goles commented 11 years ago

It was driving me insane, thanks @jhshi

MauricioA commented 11 years ago

Putting Google as default search engine without all the cryptic arguments in the url is not a solution for me because Google Instant stops working if you do that and searches become a little slower.

hellochar commented 11 years ago

I got the same results as @jhshi 's post by turning Instant off in the settings. Bit of an annoyance but it works ok for me.

nrnrnr commented 11 years ago

The link from @jhshi 's post has rotted. I sure would like to see a fix here.

hellochar commented 11 years ago

From @jhshi's post:

I added an new search engine entry and set it as default. Here is the fields of the new entry:
Name: Google (or whatever you want) 
Keyword: Google (or whatever you want) 
Search Pattern: http://www.google.com/search?q=%s

philc commented 10 years ago

Hey guys, is this still an issue? I'm unable to reproduce, and I use google instant all the time. If it is still an issue, can you provide a precise steps to reproduce, along with your version of chrome?

MauricioA commented 10 years ago

No, it seems to be solved.

nrnrnr commented 10 years ago

Looks resolved to me, too.

philc commented 10 years ago

Thanks for the info. Closing

jhshi commented 10 years ago

Yeah, it seems fixed now. Thanks!

mrap commented 9 years ago

I'm trying to patch Vimari to do this (Vimium port for Safari). Every keydown, Google's autocomplete input takes focus. How was this resolved on Vimium?

mrmr1993 commented 9 years ago

I believe it has to do with the order of injection; our content scripts are run before the JavaScript called by the page. This means that our keydown/keypress handlers are registered before the page's, and so we get the first opportunity to handle the events (and thus can block passing the events to later handlers like google's focus input handler).

Safari also runs WebKit, so to achieve the same effect you should only have to find a way to inject the Vimium code before the page can run its own javascript.

Good luck! :)

mrap commented 9 years ago

Thanks @mrmr1993, I definitely figured that, but the magical google input still grabs focus somehow. You're most definitely right, I just have to find out what I'm missing

jgarvin commented 9 years ago

This recently broke for me again. It was working fine for weeks, but not anymore. I suspect Google changed their code.

mrmr1993 commented 9 years ago

@jgarvin I can't repro this with either the current webstore version or master. Are the steps you're following the same as in the top comment here?

dylnmc commented 9 years ago

This was still happening to me in Linux Mint 17.01. What I had to do was go to Firefox's addon's manager and disable "Mint Search Enhancer."

rhys-vdw commented 5 years ago

Could this be back?

MeloMing commented 5 years ago

Could this be back?

hey,I seem to have the same problem with you,no matter I search from the Omnibox or google homepage the vimium icon is always gray，have you fixed this problem？

gdh1995 commented 5 years ago

@rhys-vdw @MeloMing Are you using Opera? It has some built-in safety limitaions causing thia issue.

MeloMing commented 5 years ago

@rhys-vdw @MeloMing Are you using Opera? It has some built-in safety limitaions causing thia issue.

I am using chrome

onejae commented 4 years ago

It's still happening to my chrome.

Flurrywinde commented 4 years ago

Opera user here. @gdh1995 I found it works again by going to Extensions and checking the box to allow access to search results.

rsha256 commented 3 years ago

yep going to opera://extensions and giving access to search results worked for me, thanks Flurrywinde!

andradefil commented 3 years ago

Opera user here. @gdh1995 I found it works again by going to Extensions and checking the box to allow access to search results.

Thank you, works for me too