search

philc / vimium

The hacker's browser.
https://chrome.google.com/webstore/detail/vimium/dbepggeogbaibhgnhhndojpepiihcmeb
MIT License
23.53k stars 2.49k forks source link

Can't use numpad for activating links #879

Open asgerhallas opened 11 years ago

asgerhallas commented 11 years ago

I have changed my hint letters to 0123456789 and are now trying to activate the links using the numpad, but nothing happens. It works fine when using the other numeric keys.

Is this by design or a bug?

Chrome: 28.0.1500.71 (Official Build 209842) m Vimium: 1.43

asgerhallas commented 11 years ago

Great extension by the way!!! :)

philc commented 11 years ago

Great bug. This will require some debugging -- I'm not sure whether we're switching on the key char or key code, but if it's the key code, that may cause different behavior between regular numbers and numpad keys.

thynctank commented 10 years ago

Was this ever fixed? I just reported an identical issue in Vrome!

dragon788 commented 9 years ago

Sadly I don't have my numpad equipped laptop nearby to test, but I'm almost certain that the numpad does send different keyscan codes than the number row, but as philc said, matching shouldn't be tough.

thynctank commented 9 years ago

I committed a fix for the equivalent issue in vrome which is working just fine for me. It was merged in but I’m not sure it’s been released to the store or whatever.

smblott-github commented 9 years ago

Looks like this is @thynctank's fix in vrome.

thynctank commented 9 years ago

Aye! Thanks for dredging it up!

On Sunday, May 10, 2015, Stephen Blott notifications@github.com wrote:

Looks like this https://github.com/thynctank/vrome/commit/3b776a8300ee56a6da6a35937fba1072adaadb75 is @thynctank https://github.com/thynctank's fix in vrome.

— Reply to this email directly or view it on GitHub https://github.com/philc/vimium/issues/879#issuecomment-100703464.

Sent from my Mobile

mrmr1993 commented 9 years ago

Alternatively, we could stop using a keydown listener for character filtering in link hints, and use a keypress one instead. This will automatically fix this issue and the internationalisation issues we've been seeing for link hints.

Edit: keypress won't work properly with modifer keys, so this won't work for us.