search

philcockfield / file-system-cache

A super-fast, promise based cache that reads and writes to the file-system.
MIT License
54 stars 14 forks source link

Fix unreturned promise warnings #5

Closed Inkdpixels closed 2 years ago

Inkdpixels commented 7 years ago

When executing the clear() method I recieve warnings that state

at new Promise (/foo/bar/node_modules/file-system-cache/node_modules/bluebird/js/release/promise.js:77:14)
(node:15947) Warning: a promise was created in a handler at foo/bar/node_modules/file-system-cache/src/cache.js:179:27 but was not returned from it, see http://goo.gl/rRqMUw

This commit fixes the issue since the promises are now properly chained and returned from the wrapping method clear().

prashantpalikhe commented 4 years ago

Can this PR be merged? Receiving the same issues.

philcockfield commented 2 years ago

Update to typescript transpiler, so promises junk a lot cleaner than the bad old days when this first got written. Thanks @Inkdpixels and @prashantpalikhe