philcockfield / ui-harness

Create, isolate and test modular UI components in React.
http://uiharness.com
MIT License
268 stars 14 forks source link

Don't try add keys to children. Fixes #85 #89

Closed frederickfogerty closed 8 years ago

frederickfogerty commented 8 years ago

This can be verified by inlining a list of components into a .component call.

E.g.

describe('css-loader', function () {
  this.header(`## Webpack simple CSS loader.`);
  before(() => {
    this
      .component(
      <div className="css-loader-sample">
        <p>{ lorem(50) }</p>
        <p>{ lorem(50) }</p>
        <p>{ lorem(50) }</p>
      </div>
      );
  });
});
philcockfield commented 8 years ago

[As discussed] This will leave warnings in the console. We'll get this out as a release, then figure out how to clone the elements and give them keys to avoid unnecessary / ugly warnings.