search

philcook / brew-php-switcher

Brew PHP switcher is a simple shell script to switch your apache and CLI quickly between major versions of PHP. If you support multiple products/projects that are built using either brand new or old legacy PHP functionality. For users of Homebrew (or brew for short) currently only.
MIT License
961 stars 90 forks source link

Update switcher to support PHP 7.3 #54

Closed chrisdeeming closed 5 years ago

chrisdeeming commented 5 years ago

PHP 7.3 was released yesterday and the relevant brew formulas were made available today so a quick merging of these changes to support php@7.3 would be greatly appreciated @philcook 🙂

ikari7789 commented 5 years ago

The script itself and the Travis scripts need updated as well to add 7.3

chrisdeeming commented 5 years ago

That's already been done, or did I miss something?

https://github.com/philcook/brew-php-switcher/pull/54/files

ikari7789 commented 5 years ago

I unfortunately can’t tag this as a release, but I can merge it so you can at least install HEAD.

chrisdeeming commented 5 years ago

No rush on my side as I've just updated my script locally but thank you very much @ikari7789 👍

ikari7789 commented 5 years ago

Looks like they already removed PHP 7.0 as well. Not sure if it should be removed immediately from this script or not considering there’s probably still people using it.

chrisdeeming commented 5 years ago

I'm actually very surprised they've taken that approach. I've asked them to reconsider:

https://github.com/Homebrew/homebrew-core/pull/34739#issuecomment-445412425

ikari7789 commented 5 years ago

I had to argue to get them to include 7.0 initially when they switched to the new system and removed the old tap. They had only wanted to include the versions under active development and had only left 5.6 because it was an old major version.

chrisdeeming commented 5 years ago

Indeed. Arguably 5.6 is even more important due to that. By their criteria there, 5.6 will be removed in 22 days when it becomes EOL at the end of this month too, which will be a shame.

cfont commented 5 years ago

so, what needs to happen for this update to trickle all the way down to us "normal" end users of homebrew and get the update? I know I grab this HEAD and have done that for other projects but it is so much nicer when we can just brew update && brew upgrade and be done with it.

ikari7789 commented 5 years ago

@cfont We'd need @philcook to tag a new version.