search

phildini / cards-against-django

CAH done as a Django web app.
Other
8 stars 4 forks source link

Preliminary game password support and join by scanning QR code #65

Closed clach04 closed 10 years ago

clach04 commented 10 years ago

Users can join password protected (and password-less) games by scanning a QR code (or manually typing in a URL).

Game creator clicks QR code button (at bottom of the game window) to display QR code.

clach04 commented 10 years ago

This change needs some help on the testing front, one test fails and I think this is a mock/factory issue (rather than a real failure).

This change possibly needs some minor re-factoring on the code view and template as the button to display a QR code was semi-randomly chosen. One option might be a link to a new view that includes the QR code and some helpful text (e.g. recommendations for known good QR code scanners for multiple platforms, e.g. https://play.google.com/store/apps/details?id=com.google.zxing.client.android ).

A new mixin for passwords may be a good idea, that throws up a password entry form when needed. Currently the QR code negates the need for this but the "denied" error is not user friendly.

[edited after getting some sleep :-)]

phildini commented 10 years ago

Not sure I understand that last comment.