search

phildini / django-sandstorm

Django Package for doing authentication with sandstorm.io
MIT License
7 stars 2 forks source link

Add support for the `X-Sandstorm-Username` header #2

Closed phildini closed 8 years ago

phildini commented 8 years ago

Possible solution to #1 /cc @paulproteus

phildini commented 8 years ago

Proof of concept/testing:

screen shot 2016-01-24 at 10 44 15 pm
paulproteus commented 8 years ago

This looks tentatively amazing.

Can you test by using a Chinese or Hindi character in your Sandstorm profile name, for Unicode sanity-checking? e.g. copy-paste this: ॐ

paulproteus commented 8 years ago

Also, I would encourage you to check if the user.first_name == the name that was unquoted. If they are equal, then don't bother modifying request.user.

phildini commented 8 years ago
screen shot 2016-01-25 at 1 06 42 pm
phildini commented 8 years ago

@paulproteus, it works, so I'm going to merge.

paulproteus commented 8 years ago

Super rad!​