phileday / whirligig-old-issues

Whirligig Media Player bug tracking
0 stars 0 forks source link

Feature request: Allow turning left and right in Fisheye mode distortion #28

Open cheater opened 5 years ago

cheater commented 5 years ago

There is a binding (I think it's called Tilt) that allows you to turn the camera view left and right in Barrel mode. However, that same binding in Fisheye mode rotates the view around the axis, which is mostly useless - I've not yet encountered a video that needed this. Please make this binding do the same thing in Fisheye mode as it does in Barrel mode: turn view left and right.

Phil's response: Hi

The rotate very specifically refers to the rotation of the projection model. With fisheye as you've noticed it rotates the fisheye round it's access. Actually you can get fisheye videos which are flipped 180 and face the other way so it's important to keep that.

It sounds like what you want is a way to rotate the user. Whirligig has position options for the user but not rotate. It might be a good idea to add rotate to this as well.

I want to improve the position option but I've never managed to come up with a decent way to do it. Once I've worked that out I'll look at add rotate to it as well :)

My response: Yeah, I mean I would keep that option for Fisheye since it's important, but I'd like to have a control that does the same thing as turning my head left and right in any projection. Yeah, rotating the user sounds good.

Phil's response: Once I've got a bug track setup hopefully this will all be better organised :)

cheater commented 4 years ago

Most likely related to #18.

It sounds like the Tilt binding as it is right now should be renamed "projection horizontal parameter", since it does so much: roll rotation in fisheye mode, yaw rotation in barrel mode, and changes aspect ratio in cinema mode. A new binding should be created to implement specifically turning the head left and right in all projection modes.

cheater commented 4 years ago

Also probably a good idea to add a binding for turning the head up and down, since otherwise you have a binding that "tilts up and down" using math based on the projection, but a binding that looks left and right using math based on the viewer camera, which will lead to discrepancies and confusion.

cheater commented 4 years ago

This also seems to be a duplicate of #7.

phileday commented 4 years ago

Checking over this we keep saying tilt. Tilt does seem to be the same in every option apart from rooms.

Rotation doesn't. This rotates around the x access in fisheye (when set at 90 degrees) and barrel and in Cinema it changes the aspect ratio. This I can see as confusing. Especially with the cinema mode.

I'm not sure how to fix this. Rotate should be renamed to something like Rotate projection and maybe the aspect ratio option could be moved to another option.

Regarding actual rotation of the view that probably should be in the position menu when you can move the person around.

cheater commented 4 years ago

I suggest doing the following:

1.Rename "Rotate" to "Roll fisheye projection". "rotate" is not specific enough - we need to indicate if it's pitch, yaw, or roll. Refer to this:

https://www.grc.nasa.gov/WWW/K-12/airplane/rotations.html

This one is clearly roll.

  1. Add a separate aspect ratio option that works for all projections, not just cinema. Call it "Aspect ratio correction". This slider should be in the advanced position menu, where you can move the person around, since it's used in the same scenarios: to get a good view of the film.

  2. Add a roll option that works for all projections: it's actually a pretty big request of mine, for some reason my driver doesn't do roll properly so all of my video is tilted to the side, as if gravity was not straight down, but a bit to the right. So being able to adjust for it would make my experience way better. But there are also many videos where the people just hold the camera wrong and it would be useful as well. Call this slider "Roll camera". I would really appreciate it if you could do this soon.

  3. Make sure the bindings screen can bind the "Roll fisheye projection", "Aspect ratio correction", and "Roll camera". Also, the "move left/right" slider is missing a binding, so add a binding for that as well.

On Tue, Mar 31, 2020 at 4:45 PM phileday notifications@github.com wrote:

Checking over this we keep saying tilt. Tilt does seem to be the same in every option apart from rooms.

Rotation doesn't. This rotates around the x access in fisheye (when set at 90 degrees) and barrel and in Cinema it changes the aspect ratio. This I can see as confusing. Especially with the cinema mode.

I'm not sure how to fix this. Rotate should be renamed to something like Rotate projection and maybe the aspect ratio option could be moved to another option.

Regarding actual rotation of the view that probably should be in the position menu when you can move the person around.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/phileday/whirligig/issues/28#issuecomment-606672818, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABPWPUSMLDYASQHA4A2XXTRKH6ZJANCNFSM4IEKJHBA .