Should this be a plus sign?

philferriere / tfoptflow

Optical Flow Prediction with TensorFlow. Implements "PWC-Net: CNNs for Optical Flow Using Pyramid, Warping, and Cost Volume," by Deqing Sun et al. (CVPR 2018)

MIT License

519 stars 136 forks source link

Should this be a plus sign? #33

Open ruizengalways opened 4 years ago

ruizengalways commented 4 years ago

https://github.com/philferriere/tfoptflow/blob/bdc7a72e78008d1cd6db46e4667dffc2bab1fe9e/tfoptflow/core_warp.py#L194

Superlee506 commented 4 years ago

@ruizengalways I also wonder about this

JunggiLee12 commented 4 years ago

Is there any improvement of that~?

shuaiyuan1996 commented 4 years ago

This has been discussed in this previous issue #6.

yaanggny commented 2 years ago

I believe a plus is required here. What we need is the remap image from image2. so we need + rather than a "-".

Besides, we can warp an image pair using the flow, the minus way generates bad result of alignment, but the plus one really align the images. see this comment