philfung / add-to-homescreen

Easily add a website to a user's home screen on IOS/Android/Desktop
MIT License
103 stars 25 forks source link

Can't get the overlay to appear on click #29

Closed NilsDannemann closed 1 week ago

NilsDannemann commented 1 week ago

I can get it to work as in your demo page (overlay shows up after load).

But I need it to appear on click. I'm getting a strange error, where the overlay vanishes again immediately after click.

Is this a known issue?

Video of the issue: https://github.com/user-attachments/assets/3cda718b-4547-4b35-8b87-9187a83fd3e4

Site for testing: https://66dccab93975a80008b04ebd--little-dayplanner.netlify.app/

philfung commented 1 week ago

Hello! Someone else had this same issue. They were missing an event.stoppropogation() in the click handler. Can you try that? If doesn't work will try to debug

Example

https://gist.github.com/philfung/f4b152aa3c57f29bc5b180a16562548a

Thanks!

NilsDannemann commented 1 week ago

Oh my god, yeah that works. Thank you so much man!

philfung commented 1 week ago

Thanks for trying the library Nils! Appreciate it you can give the repo a "star".

On Sun, Sep 8, 2024, 2:19 AM Nils Dannemann @.***> wrote:

Closed #29 https://github.com/philfung/add-to-homescreen/issues/29 as completed.

— Reply to this email directly, view it on GitHub https://github.com/philfung/add-to-homescreen/issues/29#event-14173679335, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIBPALXEHR7DELUWEXW6FTZVQJBNAVCNFSM6AAAAABN2LR4S6VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJUGE3TGNRXHEZTGNI . You are receiving this because you commented.Message ID: @.***>

NilsDannemann commented 1 week ago

Will do 👍