search

philhartung / aes67-monitor

AES67 Stream Monitor: Monitor AES67 streams directly
https://aes67.app
MIT License
236 stars 23 forks source link

Redundant Streams are not recognized correctly #2

Closed philhartung closed 3 years ago

philhartung commented 3 years ago

Redundant streams are not recognized correctly, as there are two mediatype definitions in the SDP. A SDP for a redundant stream might be similar to the following (adopted from [1]):

v=0
o=- 1311738121 1311738121 IN IP4 192.168.1.1
s=Stage left I/O
t=0 0
m=audio 5004 RTP/AVP 96
c=IN IP4 239.0.1.1/32
i=Channels 1-8
a=rtpmap:96 L24/48000/8
a=recvonly
a=ptime:0.125
a=ts-refclk:ptp=IEEE1588-2008:39-A7-94-FF-FE-07-CB-D0:0
a=mediaclk:direct=963214424
m=audio 5004 RTP/AVP 96
c=IN IP4 239.0.2.1/32
i=Channels 1-8
a=rtpmap:96 L24/48000/8
a=recvonly
a=ptime:0.125
a=ts-refclk:ptp=IEEE1588-2008:39-A7-94-FF-FE-07-CB-D0:0
a=mediaclk:direct=963214424

Implementing stream redundancy correctly is quite a big task and would need a lot of testing. As a workaround I will ignore the second mediatype definition to support redundant streams.

[1] https://www.aes.org/standards/comments/drafts/aes67-r-171107-draft-rev-cfc.pdf

philhartung commented 3 years ago

Should be fixed with f090a8d but still needs testing.

philhartung commented 3 years ago

Manually added SDPs are recognized properly.

Disclaimer: Redundancy is NOT implemented though, this is only a workaround to support redundant streams!