philhk / better-discord-screenshare-plugin

With this plugin you can customize your resolution, framerate, bitrate and more for your screenshare on discord!
GNU General Public License v3.0
25 stars 8 forks source link

can you make vencord version of these plugins #19

Closed Cxsmo-ai closed 1 year ago

Cxsmo-ai commented 1 year ago

can you make vencord version of these plugins https://github.com/Tharki-God/BetterDiscordPlugins/blob/master/DiscordBypasses.plugin.js https://github.com/riolubruh/SplitLargeFiles and the custom camera quality from this plugin because without it discord caps camera to 720p https://github.com/riolubruh/YABDP4Nitro

Cxsmo-ai commented 1 year ago

i posted this here because your vencord repo doesn't let me post there.

philhk commented 1 year ago

I might make a plugin in the future that lets you customize your camera :). And if you want to make plugin requests, please do so in the original repo and not my fork. SplitLargeFiles is already being ported to Vencord to my knowledge, but I don't know if it will be accepted. And if you want to report any issues for my plugins (BetterScreenshare or BetterMicrophone) it would be great if you just comment here. I also saw that you opened an issue earlier and if you still need help, just ask on the official Vencord Discord.

philhk commented 1 year ago

I have news for you. I was trying to create a plugin to customize your camera but issue is Discord actually has a resolution limit of 720p. I can't say 100% that it's server-side, but the chance of it being server-side is really really high. You can still adjust the framerate and bitrate, but that seems a bit useless if you can't change the resolution. I also tested YABDP4Nitro and it has the same problem that anything over 720p is downscaled to 720p. You'll see the resolution you set on your client in your preview, but everyone else won't. You can also check it yourself like this:

image image

ThaUnknown commented 1 year ago

afaik camera is also hardcoded on desktop, like screenshare is hardcoded on web as I've mentioned here