search

philhk / better-discord-screenshare-plugin

With this plugin you can customize your resolution, framerate, bitrate and more for your screenshare on discord!
GNU General Public License v3.0
25 stars 8 forks source link

The code is just Licenses #21

Closed Jaie55 closed 1 year ago

philhk commented 1 year ago

I'm aware that the code isn't that great, but firstly this is my code and this is what it looks like and secondly did you really just opened an issue to tell me my code is shit? Suggestions for improving my code are always welcome, but what you did was just completely unnecessary. I also started this as a side project and didn't really bother at first, and do you even know how hard it is to figure out how all these things work? I never thought I'd get hate for something like this, but I think it can happen on Github too. And the most hilarious thing about all this is that you are not even criticizing my code, but the compiled and minified code that comes from building the plugin (the one in the releases tab) 😂. If you want to look at the real code this is it.

jupelost commented 1 year ago

Lmao what an asshole ignore him I appreciate you for this plug-in it has been one of the best features I believe should just be shipped with vanilla discord tbh you’re a lifesaver and a goat On Apr 28, 2023, at 2:06 PM, Phil @.***> wrote: I'm aware that the code isn't that great, but firstly this is my code and this is what it looks like and secondly did you really just opened an issue to tell me my code is shit? Suggestions for improving my code are always welcome, but what you did was just completely unnecessary. I also started this as a side project and didn't really bother at first, and do you even know how hard it is to figure out how all these things work? I never thought I'd get hate for something like this, but I think it can happen on Github too. And the most hilarious thing about all this is that you are not even criticizing my code, but the compiled and minified code that comes from building the plugin (the one in the releases tab) 😂. If you want to look at the real code this is it.

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: @.***>

philhk commented 1 year ago

I am very happy that you like it! Sadly there will always be people like him :/.

Am Fr., 28. Apr. 2023 um 20:41 Uhr schrieb jupelost < @.***>:

Lmao what an asshole ignore him I appreciate you for this plug-in it has been one of the best features I believe should just be shipped with vanilla discord tbh you’re a lifesaver and a goat On Apr 28, 2023, at 2:06 PM, Phil @.***> wrote: I'm aware that the code isn't that great, but firstly this is my code and this is what it looks like and secondly did you really just opened an issue to tell me my code is shit? Suggestions for improving my code are always welcome, but what you did was just completely unnecessary. I also started this as a side project and didn't really bother at first, and do you even know how hard it is to figure out how all these things work? I never thought I'd get hate for something like this, but I think it can happen on Github too. And the most hilarious thing about all this is that you are not even criticizing my code, but the compiled and minified code that comes from building the plugin (the one in the releases tab) 😂. If you want to look at the real code this is it.

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/philhk/better-discord-screenshare-plugin/issues/21#issuecomment-1527951216, or unsubscribe https://github.com/notifications/unsubscribe-auth/AP63KZ36YDZ5C7V3JXEVUKDXDQFODANCNFSM6AAAAAAXPOMU7Q . You are receiving this because you commented.Message ID: @.***>

Jaie55 commented 1 year ago

I didn't say that i don't like it, the thing is that i can not understand the code because is just 9000000 lines of LICENSES, so thats it. I apologize about that, anyways, is there any way to make it wokrs in Vencord, i did compile the Vencord fork, but i don't know how to install it

philhk commented 1 year ago

First of all you need to install git and NodeJS. After that open a PowerShell as administrator and type in Set-ExecutionPolicy -ExecutionPolicy RemoteSigned -Scope LocalMachine and enter. Now search for a place where you want to store Vencord. Open a Command Line there and then type all of this stuff in there

git clone https://github.com/philhk/Vencord.git
npm install -g pnpm
pnpm install
pnpm build
pnpm inject