philhk / better-discord-screenshare-plugin

With this plugin you can customize your resolution, framerate, bitrate and more for your screenshare on discord!
GNU General Public License v3.0
26 stars 8 forks source link

Crash Discord #7

Open NhProGamer opened 1 year ago

NhProGamer commented 1 year ago

This plugin totaly crash discord on load

NhProGamer commented 1 year ago

Okayy, the problem comes from Betterdiscord, just install it with the manual method --> [https://docs.betterdiscord.app/users/getting-started/installation/#manual-installation]()

philhk commented 1 year ago

I've noticed it with recent versions of Discord as well. I haven't looked that deeply into the issue because I'm trying to port the plugin and submit it to Vencord anyway. If I'm successful I'll update the repo. Thanks for the solution👍.

Cxsmo-ai commented 1 year ago

same with me on discord stable

EndlessVoidDev commented 1 year ago

image Discord_ZcK28NWMK3

crash when choosing screen

Cxsmo-ai commented 1 year ago

exactly the same for me i want to use this over YABDP4Nitro but this happens good i at least have that as a backup even though this plugin way superior to YABDP4Nitro the main reason i use custom resolution and stuff is to get the best quality bitrate resolution no lag ever almost 1080p or 1080p 120fps or 63fps full screen with audio screenshare combined with obs window projector with application audio capture

philhk commented 1 year ago

Hey, too bad the plugin doesn't work anymore. I made a plugin for Vencord that does exactly what this plugin does, but better. Unfortunately the plugin hasn't been merged yet, but I'm hoping that will be the case in the next few days or weeks, as the repository owner has many other PRs to check, so I'll have to wait. Here is a link to my fork. You can build it yourself with this guide and then use my plugin. I probably wont update this repository anymore.

Cxsmo-ai commented 1 year ago

the crash still happens on the latest better discord and i want a better discord version still because there are plugins vencord does not have that stop me from switching over

jupelost commented 1 year ago

Hey, too bad the plugin doesn't work anymore. I made a plugin for Vencord that does exactly what this plugin does, but better. Unfortunately the plugin hasn't been merged yet, but I'm hoping that will be the case in the next few days or weeks, as the repository owner has many other PRs to check, so I'll have to wait. Here is a link to my fork. You can build it yourself with this guide and then use my plugin. I probably wont update this repository anymore.

I tried building your fork however it doesn't seem to be working i checked discord settings as well to see if the vencord section was there and it seems like it isnt injecting vencord at all

aceyx3 commented 1 year ago

Same for me. Same problem as jupelost.

philhk commented 1 year ago

That's weird. When you run "pnpm inject" does a new window appear? If not, can you send me the logs of the terminal.

aceyx3 commented 1 year ago

It does show the installation window after I run the pnpm inject. Though after patching, nothing appears in the settings menu.

philhk commented 1 year ago

image When you click this button do you get an error? If so you need to close Discord before clicking Install.

jupelost commented 1 year ago

https://user-images.githubusercontent.com/94334900/231865992-519e6443-1626-4dee-a996-ef4961b4557f.mp4

maybe im missing something?

aceyx3 commented 1 year ago

maybe im missing something?

Same for me.

philhk commented 1 year ago

Ok, I found the issue, it was a problem with my plugin. Just type "git pull" in the command line (if you don't have git just download the repository again) then reinstall with "pnpm inject" and it should work.

jupelost commented 1 year ago

Beautiful, it worked!

philhk commented 1 year ago

Great! Thanks for helping me find the bug.

aceyx3 commented 1 year ago

Ok, I found the issue, it was a problem with my plugin. Just type "git pull" in the command line (if you don't have git just download the repository again) then reinstall with "pnpm inject" and it should work.

When should I type git pull? After I clone the repo?

philhk commented 1 year ago

You don't have to clone again, you can just use "git pull", it's updating the old version you currently have, but you can also clone the whole repo again if you want.

aceyx3 commented 1 year ago

Thank you so much! Works flawlessly, cheers!

jupelost commented 1 year ago

literally doing gods work hope it becomes an official plugin soon :)!

LavenderAndChamomile commented 8 months ago

image Discord_ZcK28NWMK3

crash when choosing screen

Same here