[Intro to iOS] Project 1 - Review my app

philihp / kazantip

Codepath Assignment #0

0 stars 0 forks source link

[Intro to iOS] Project 1 - Review my app #1

Open philihp opened 8 years ago

philihp commented 8 years ago

My app is complete, please review. /cc @codepathreview

nesquena commented 8 years ago

Philihp,

Looks good, this exercise is intended in part to give you an introduction to the general rhythm of this course. The course is entirely project-based with an app being assigned each week and then due the following week. Each project builds on the last to help each engineer to learn all practical iOS development and best practices as quickly as possible. We also do a code review for each submitted project once the program begins.

Great to see you were able to complete a few extension tasks as well. The extension tasks available on each project are often the most valuable learnings since they dive deeper into common real-world iOS use cases.

Your application will be passed along for final admissions. You should hear back again soon. I'd encourage you to continue working on app extensions. Let me know if you have any questions in the meantime.

philihp commented 8 years ago

Hi @codepathreview

Additional features, could I get more review?

It dawned on me that the theme switcher should be a switcher, so I added that. Light/dark seems silly when iOS already has brightness, so I made HIGH VISIBILITY miami vice theme. That's actually useful.
Figured out how to becomeFirstResponder() works.
Saved tip amount now. More optional features.
Feels like there were more... my animation is still not working, so I didn't commit it, and Christian said EOD Monday, so I wanted this in before then. "Better never than late" is how the saying goes, right?
?. operator in Swift seems dope, I wish we had that in Ruby instead of try. As are extensions. Learning more about the language but OH GOD it is painful to knowingly submit messy code that should be refactored.

kazantip2

nesquena commented 8 years ago

Thanks for submitting a few more additions and for the notes, we will definitely consider the updated app as we do our final admissions.

?. operator in Swift seems dope, I wish we had that in Ruby. As are extensions. Learning more about the language but OH GOD it is painful to knowingly submit messy code that should be refactored.

Yes that is one of the more handy operators in swift and swift definitely takes optionals very seriously. Glad you were able to learn more about the language.

We'll be in touch again soon.