Rename variables to match paper

philihp / openskill.js

A faster, open-license alternative to Microsoft TrueSkill

https://www.npmjs.com/package/openskill

MIT License

193 stars 17 forks source link

Rename variables to match paper #203

Open philihp opened 2 years ago

philihp commented 2 years ago

Refactor and rename variables in the src/models/ such that they match the variables defined in the PDF. This will make the code easier to maintain and perhaps help others port to other languages.
e.g. sigSqToCiq should probably be some variation of qEta, since it's related to η_q defined on page 287, §3.1.1
The unit tests should protect you from making any catastrophic changes.

mstofirova commented 2 years ago

Hello, can I work on this?

philihp commented 2 years ago

Go for it :)

Please ask questions if you get stuck on anything. I would suggest a different and separate PRs for each model, and perhaps another that renames config vars to be more in line with the paper. I would prefer multiple smaller, incremental PRs.

philihp commented 2 years ago

"EPSILON" should be "KAPPA"