Board backgrounds - Githubissues

philihp / weblabora

Ora et Labora boardgame simulation library

http://kennerspiel.com

Apache License 2.0

11 stars 2 forks source link

Board backgrounds #94

Closed adambadura closed 11 years ago

adambadura commented 12 years ago

Make images for background cells:

Water
- Values
Coast
Plains
- Moor icon
- Forest icon
Hills
Mountain

philihp commented 12 years ago

Like some placeholder images?

adambadura commented 12 years ago

Yeah... So to reasamble original board and provide clear visual sign of what terrain type it is. In second thoughts I think this could (should?) be done as CSS background. SVGs are supposed to be handled there to yet I didn't manage to make it work like that.

And by the way what is surrent policy? Are we using SVG or raster images? What do we plan to end with?

philihp commented 12 years ago

Current policy is if it works, go with it :)

Eventually they will be raster jpgs and pretty. I only really bother with SVGs because they're easy to edit and generate at runtime

On Oct 11, 2012, at 2:59 PM, Adam Badura notifications@github.com wrote:

Yeah... So to reasamble original board and provide clear visual sign of what terrain type it is. In second thoughts I think this could (should?) be done as CSS background. SVGs are supposed to be handled there to yet I didn't manage to make it work like that.

And by the way what is surrent policy? Are we using SVG or raster images? What do we plan to end with?

— Reply to this email directly or view it on GitHub.

adambadura commented 12 years ago

In commit 896cb235d4 (branch issue-94) I have added changes regarding cell type backgrounds:

Code refactorization to separate terrain type (water/coast/plains/hillside/mountain) from what is placed on it (forest/moor/building/empty).
Background SVG images placeholders (which for now are just rectangles of corresponding solid color).
CSS changes to show the images.
Change in the previous "cell info" text.

At least consider merging this to master.

Issues remaining:

Change color of forest to a darker one since current is either same or to close to background color.
Provide some nice graphics for the background image placeholders.
Clean up sizes. Default building/background size (300x500) doesn't match (in proportion) board cell size (95x147).

adambadura commented 11 years ago

I noticed that master has now backgrounds for cell types. Is this in any way related to this issue? How and as a part of which issue was it done? Maybe this one should be closed?

philihp commented 11 years ago

Yeah I merged in that branch you had. Everything in it seemed complete and good to go. I suppose we can close this!