philikon / BarTab

Firefox add-on: Drink now, pay later: put your tabs on your bar tab!
https://addons.mozilla.org/firefox/addon/67651/
64 stars 30 forks source link

Unloaded tab closed if (1) has childs and (2) is in root #118

Open mkravchuk opened 13 years ago

mkravchuk commented 13 years ago

There are actually two issues: 1) if the tab is in root tree and has children - then after unload all tree are closed! 2) if tab has some parent - then after unload it moves to the end of owner node

I have found a resolution and tested the fix. To fix this issue we should move the new tab (that replace actual tab) only after reassigning parent tabs to it, because whenever we assign a tab to owner tab - owner tab moves to the end of the tree.

Actual fix is: in the file "modules\prototypes.js" move the line ---tabbrowser.moveTabTo(newtab, aTab._tPos + 1); after the if condition ---// Restore tree when using Tree Style Tab ---if (tabbrowser.treeStyleTab) {

tested system: Windows 7 (x64) Firefox version: 3.6 tested plug-in version: 2.1b2

Please publish this fix as as possible as this is a critical issue.