philikon / BarTab

Firefox add-on: Drink now, pay later: put your tabs on your bar tab!
https://addons.mozilla.org/firefox/addon/67651/
64 stars 28 forks source link

Bookmarks: Open All in Tabs overwrites tapped tabs #18

Closed philikon closed 14 years ago

philikon commented 14 years ago

Troy Hoshor writes:

"I recently closed Firefox with some ~86 tabs in the session (yes, a LOT). When I loaded Firefox back up, it restored those tabs, and BarTab did its thing, greying out the tabs, etc. I did a quick scan to make sure everything was there. It was.

Then I went to one of my common bookmark folders and selected "Open All In Tabs." This opened up 7 new tabs (7 bookmarks in that folder). HOWEVER-- the items in the tabs were the first 7 tabs that were in barTab (eg. tabs 1-7 of the 86)! When I visited each of these bizarre new tabs, it appeared to show the name of the bookmark I'd intended to open for a split second as the Tab Name before loading the strange old tab. WORSE-- once this command happened, I lost tabs! As a debug step, I scroled to the top of my Tab list, only to find that tabs 1-60 or so were missing! The only tabs that remained, accessible, were the tabs I could visually see at the time I clicked "Open All In Tabs"."

philikon commented 14 years ago

Clint Phillips reports:

"I use the bookmark tool bar all the time to bookmark my most common sites that I visit. I have folders setup so I can easily right click and open all in tabs. Here lies the problem. Doing this with all my tabs not yet loaded, the boomarks just don't open, or in repeated retries, some may open. If I am to scroll through all the unloaded tabs so they load and then go back and open all, the folder will open all tabs every time. Ive also seen if I have a few tabs loaded, that the open process will open that many bookmarks from the folder in my bookmark toolbar, but does seem sporadic also."

philikon commented 14 years ago

I can reproduce this when the popular Tab Mix Plus extension is installed. Both Troy and Clint seemed to have it installed.

philikon commented 14 years ago

Improved compatibility with the Tab Mix Plus extension.

Tab Mix Plus reuses blank tabs when opening tabs from e.g. bookmarks, and it confuses tabs on the bar tab with blank ones. BarTab now makes sure that this no longer happens.

Closed by 5aec4b1e7dd7621a7d550df76939727c5cefb8e1