search

philikon / BarTab

Firefox add-on: Drink now, pay later: put your tabs on your bar tab!
https://addons.mozilla.org/firefox/addon/67651/
64 stars 28 forks source link

Incompatibility with TabPopup #41

Closed qwerty017 closed 14 years ago

qwerty017 commented 14 years ago

Your extension seems to be somewhat incompatible with the extension Tab Popup. Before tabs have loaded Tab Popup shows about:blank as the URL of the tab. I tried another extension similar to yours, "Load tabs progressively", and it is able to show the correct URL of the unloaded tabs. Would it be possible for you to implement whatever fix they used so that Tab Popup shows the unloaded tabs correct URL?

philikon commented 14 years ago

I agree that this would be nice to have. Technically speaking this is a dupe of issue #36 (both involve making browser.currentURI work for unloaded tabs). Closing this.

qwerty017 commented 14 years ago

Ah. Cool. Thanks for taking a looking into it on another ticket. :)

philikon commented 14 years ago

Actually, solving #36 hasn't solved this :(. Just had a closer look at TabPopup, it uses browser.contentWindow.location rather than browser.currentURI. That'll be much harder to fake.

qwerty017 commented 14 years ago

Take a look at Load Tabs Progressively. I don't know how they did it but however they got it to work it works perfectly.

philikon commented 14 years ago

Use docshell.setCurrentURI() to fake currentURI. This will make sure that window.location pointed to the right URI as well.

Solves compatibility issues with extensions such as Tab Popup. Closed by 3c59d6096d6bc3bb120884be98b546934cc1f986.