Clicking link for foreground tab - Githubissues

philikon / BarTab

Firefox add-on: Drink now, pay later: put your tabs on your bar tab!

https://addons.mozilla.org/firefox/addon/67651/

64 stars 28 forks source link

Clicking link for foreground tab #44

Closed qwerty017 closed 14 years ago

qwerty017 commented 14 years ago

Previously in the 1.6 beta when clicking on a link that opens a tab in the foreground it would automatically load as designed. With the latest Beta the following is happening instead.

Go to http://forum.xda-developers.com/showthread.php?p=2718492#post2718492 Left-Click on link under "Solved!". New tab is automatically loaded. When clicking on this new tab it removes the URL from the Location Bar and replaces it with about:blank If I then refresh the page the correct URL is placed back into the Address Bar and stays.

philikon commented 14 years ago

Are you using an add-on like Tab Mix Plus to modify tab behaviour (e.g. prevent tabs from loading in the foreground?). Because I can't reproduce this bug on a bock standard Firefox instance with BarTab 2.0b2 installed.

qwerty017 commented 14 years ago

No. I just changed browser.tabs.loadDivertedInBackground to "true" in about:config

philikon commented 14 years ago

Ah yes. Confirmed. Thanks for the report! That definitely has to be fixed.

qwerty017 commented 14 years ago

BTW, I appreciate you looking into these and not getting mad. I had another addon developer do that and it put me off Bug reporting for a while. :)

philikon commented 14 years ago

So far this is what I've been able to track down:

window.browserDOMWindow.openURI() (as implemented by nsBrowserAccess) is called with a null URI.
The caller probably is nsContentTreeOwner::ProvideWindow (https://bugzilla.mozilla.org/show_bug.cgi?id=323810).
This in turn seems to be called by nsWindowWatcher::OpenWindowJSInternal. It obtains the docshell from the returned window object and then simply does newDocShell->LoadURI(), bypassing BarTab entirely.

We may have go to back to using progress listeners after all...

philikon commented 14 years ago

Handle tabs that are opened in the background but loaded by C++ code (e.g. when 'browser.tabs.loadDivertedInBackground' is enabled) correctly.

Closed by 45c49e7d43f95238fff72e9a6c4e8e8ca56dfe6f

philikon commented 14 years ago

Just released 2.0b3 containing that fix. Let me know if you run into any other problems.

qwerty017 commented 14 years ago

Awesome. Absolutely awesome. Works perfectly. Even keeps foreground tabs on the tap now. :) If I find anything else I will let you know.

philikon commented 14 years ago

Foreground tabs? How do you mean?

qwerty017 commented 14 years ago

Before in http://github.com/philikon/BarTap/issues/closed#issue/42 you said the reason it was loading was that it was set to open a foreground tab. Now, by setting the about:config entry it is read as a background tab so TabBar puts it on the tap. Exactly as expected since it is now considered a background tab by Firefox.

philikon commented 14 years ago

Ok!

qwerty017 commented 14 years ago

:) Man you are fast with the fixes.