search

philip-brink / DragAndDropLists

Flutter package for drag-and-drop reordering of two-level lists
BSD 3-Clause "New" or "Revised" License
253 stars 128 forks source link

disable scrolling #16

Closed bystrovsv closed 3 years ago

bystrovsv commented 3 years ago

Hi. Is it possible to block scrolling? Scrolling looks strange in limited space.

philip-brink commented 3 years ago

Hi @bystrovsv , I added this option in the new version 0.2.9. To do so, set disableScrolling to true in the DragAndDropLists.

bystrovsv commented 3 years ago

I checked, almost. Horizontal scrolling of lists has been disabled. But vertical scrolling of one list still works

philip-brink commented 3 years ago

Please can you provide example code for the one that isn't working for you?

bystrovsv commented 3 years ago

https://github.com/0rbb/sample_dd

philip-brink commented 3 years ago

You're using a CustomScrollView, so it's not the DragAndDropLists that is scrolling. You just need to add a property physics: NeverScrollableScrollPhysics(), to your CustomScrollView.

bystrovsv commented 3 years ago

Added NeverScrollableScrollPhysics in sample. Scrolls

philip-brink commented 3 years ago

See 0.2.9+1.

bystrovsv commented 3 years ago

Without changes.

philip-brink commented 3 years ago

You'll need to provide some more details. Where and when exactly is it scrolling for you?

bystrovsv commented 3 years ago

I run project sample_dd in Chrome. I hover over the list and scroll vertically with the wheel. The list moves a little.

philip-brink commented 3 years ago

Ok great, that helped, it should be fixed now for the horizontal lists. Could you try with v. 0.2.9+2?

bystrovsv commented 3 years ago

It work. Thank a lot