philip-brink / DragAndDropLists

Flutter package for drag-and-drop reordering of two-level lists
BSD 3-Clause "New" or "Revised" License
253 stars 128 forks source link

Error in debug console when dragging item in long list #9

Closed mivoligo closed 3 years ago

mivoligo commented 3 years ago

I've got this with BasicExample as well as with DragHandleExample. When list is longer than screen and I drag item from the top of the list to somewhere down, debug console is not happy:

════════ Exception caught by gesture library ═══════════════════════════════════
The following assertion was thrown while routing a pointer event:
setState() called after dispose(): _DragAndDropItemWrapper#6cf44(lifecycle state: defunct, not mounted, tickers: tracking 1 ticker)

This error happens if you call setState() on a State object for a widget that no longer appears in the widget tree (e.g., whose parent widget no longer includes the widget in its build). This error can occur when code calls setState() from a timer or an animation callback.

The preferred solution is to cancel the timer or stop listening to the animation in the dispose() callback. Another solution is to check the "mounted" property of this object before calling setState() to ensure the object is still in the tree.
This error might indicate a memory leak if setState() is being called because another object is retaining a reference to this State object after it has been removed from the tree. To avoid memory leaks, consider breaking the reference to this object during dispose().
philip-brink commented 3 years ago

Hi @mivoligo, thanks! I've added a fix to this in v 0.2.4.