Remove deprecated text theme getters

philip-brink / DragAndDropLists

Flutter package for drag-and-drop reordering of two-level lists

BSD 3-Clause "New" or "Revised" License

253 stars 128 forks source link

Remove deprecated text theme getters #97

Open philitell opened 4 months ago

philitell commented 4 months ago

Error when running on flutter 3.22:

drag_and_drop_lists-0.3.3/lib/programmatic_expansion_tile.dart:236:33: Error: The getter 'subtitle1' isn't defined for the class 'TextTheme'.

I think this section needs to be updated:

  @override
  void didChangeDependencies() {
    final ThemeData theme = Theme.of(context);
    _borderColorTween.end = theme.dividerColor;
    _headerColorTween
      ..begin = theme.textTheme.subtitle1!.color   // ****** use correct getter ******* e.g. bodySmall or titleSmall
      ..end = theme.colorScheme.secondary;

philitell commented 4 months ago

Thanks for this great package - i'm using it in two projects and it works great

dmitry-comet commented 4 months ago

https://github.com/philip-brink/DragAndDropLists/pull/98

decisionslab2 commented 4 months ago

same issue in Flutter 3.22

philitell commented 4 months ago

Please release #98

florinleu commented 4 months ago

I think no one is maintaining this package anymore. And unfortunately this issue is blocking us from upgrading to flutter 3.22 and above.

paulHempel commented 4 months ago

Workaround with #98 fork (thanks @dmitry-comet):

  drag_and_drop_lists:
    git:
      url: https://github.com/dmitry-comet/DragAndDropLists.git
      ref: 04715d15ec1a679cf0bc4fcfada75155c9443388

Replace the current version in your pubspec.yaml with the git commit.

philip-brink commented 3 months ago

Apologies for the long delay, I haven't been using flutter at all for quite a while. I've merged in #98 (thanks @dmitry-comet !) and published as v 0.4.0.