converter ignores functions with names in upper case

philip / MySQLConverterTool

A MySQL Converter Tool

314 stars 144 forks source link

converter ignores functions with names in upper case #15

Closed semoriil closed 8 years ago

semoriil commented 8 years ago

Such functions left untouched:

MYSQL_QUERY
MYSQL_ESCAPE_STRING
MYSQL_FETCH_OBJECT while in lower case all was changed.

semoriil commented 8 years ago

workaround: preprocess files with something like sed -i -re s/\\\<$mysql_\\w+$\\\>/\\L\\1/gi your.php

semoriil commented 8 years ago

Converter checks for function name in such way: if (isset($this->mysql_funcs[$text])) And $this->mysql_funcs is array with supported function names in lowercase as keys.

philip commented 8 years ago

Interesting issue, agreed that it needs to be fixed. Adding this to the #1 todo.

semoriil commented 8 years ago

I forked this repo and got this fixed in mine. But not really tested. Same for mysql_set_charset - just added required classes (not me). my fork

Not sure what to do with this...

philip commented 8 years ago

This was fixed via pull request #17 -- thank you for the bug report!