philip / MySQLConverterTool

A MySQL Converter Tool
314 stars 144 forks source link

Parse Error #26

Closed Rhyfelwr closed 2 years ago

Rhyfelwr commented 7 years ago

Convert a file

Parse error: syntax error, unexpected T_FUNCTION, expecting ')' in /opt/lampp/htdocs/MySQLConverterTool-master/Converter.php on line 364

philip commented 7 years ago

Interesting and surprising, thanks for the report, I'll take a look on Monday.

philip commented 7 years ago

The code that generates that parse error uses anonymous functions that were added in PHP 5.3. The code was added in change a1dee30cde9f2c6cef2da0a196fa48d04c60e36a about a year ago, and then updated via a58fc775df0654ea0e6060150b2ca1eda9d91e86 a little while later.

It'd make sense for MySQLConverterTool to work in older PHP versions as this converts old MySQL code, so I'll look into this later this week and hopefully make all the code work with old PHP versions again.

Thanks for the report.

Rhyfelwr commented 7 years ago

Hi Philip

I ran this on php Ver 5.2.0 which would explain it!

It’s on an old internal LAMP machine, hence the upgrade in code before we upgrade the platform.

Glad it helped!

philip commented 7 years ago

@Rhyfelwr Please give it another try with the latest change (change #dc496d1) and hopefully this fixes the issue. I don't have PHP 5.2 or lower to test right now, but will do so eventually.