search

philip1986 / pimatic-led-light

A template for creating plugins
http://pimatic.org/
GNU General Public License v2.0
7 stars 13 forks source link

setColor in color_action.coffee #19

Closed tester22 closed 8 years ago

tester22 commented 9 years ago

Hi,

This code breaks rules for me: https://github.com/philip1986/pimatic-led-light/blob/master/predicates_and_actions/color_action.coffee#L36

What is the purpose of this function?

philip1986 commented 9 years ago

Hi,

the purpose is to change the color of the light device. So you could have a rule like: "if ... than set device to red "

Can you please provide an example of the breaking rules.

tester22 commented 9 years ago

Hi.

My rule is as simple as:

set blinkstick to red

The error message is setColor: is undefined.

When removing this code the rule works as expected (changeing color to red).

13 jul 2015 kl. 10:07 skrev philip1986 notifications@github.com:

Hi,

the purpose is to change the color of the light device. So you could have a rule like: "if ... than set device to red "

Can you please provide an example of the breaking rules.

— Reply to this email directly or view it on GitHub.

tester22 commented 9 years ago

Another user seems to have the same issue after the last update: http://forum.pimatic.org/topic/687/problems-with-color-change-pimatic-led-light-plugin-with-milight

philip1986 commented 9 years ago

@tester22 you are right the code at this line is broken. It will be fixed soon.

philip1986 commented 8 years ago

fixed by https://github.com/philip1986/pimatic-led-light/pull/25