search

philip1986 / pimatic-led-light

A template for creating plugins
http://pimatic.org/
GNU General Public License v2.0
7 stars 13 forks source link

Development #23

Closed Xento closed 8 years ago

Xento commented 9 years ago

I hope you can merge it. I tried to merge your changes into my fork, but I couldn't handle it. I'm to unexperienced with the git commandline.

Xento commented 9 years ago

I think now I got everything correct ;-)

philip1986 commented 9 years ago

Could you please also add some commands to the code, specially how the classes MilightRF24 and MilightRF24Zone are interconnected.

Xento commented 9 years ago

I added some comments and improved the code

Xento commented 9 years ago

Are this enough comments?

philip1986 commented 9 years ago

Yes, thanks a lot. I will take some time to add some tests for it (I do it for all devices), because the complexity of the whole plugin makes it necessary.

Xento commented 8 years ago

When you will merge it? Its running very smooth ;-)

philip1986 commented 8 years ago

Sorry, its been a while. As I told you I like to have some tests for the plugin. So, I took your branch and add some basic ones. Would be nice if you extend then, e.g. when one device isn't in zone 0. I also did a change about the configuration and initialization of milightRF24, because I didn't like the approach to set the port via the device config.

I am going to close this PR and open a new one with my modifications. Please have a look at it.

Cheers, Philip