philip1986 / pimatic-led-light

A template for creating plugins
http://pimatic.org/
GNU General Public License v2.0
7 stars 13 forks source link

Feature/support multiple drivers #3

Closed philip1986 closed 9 years ago

Fjuxx commented 9 years ago

The interface looks good!

But 1 note, wouldn't it be better to have the device no be a setting?

Because first off, this means that the end user can make a mistake easily. but also:

my proposal: Create a Device according the interface. But make it the same as the devices in pimatic: https://github.com/pimatic/pimatic/blob/master/lib/devices.coffee So no functionalities.

Then (for now) 3 devices, 1 for Milight (and compatible), 1 for IWY (if this is not compatible with milight), and 1 for Wifi370.

Those 3 devices will extend the first device. (the same way you would extend any existing device template in pimatic)

And then have there own code. This way you can adjust every device specific to the needs of that device, without having to worry about the other device's. But all of the devices share the same template/interface device.

Also, Sweetpi could integrate the "interface device" into the core, so that other people could create a plugin with those functions as well.