search

philip1986 / pimatic-led-light

A template for creating plugins
http://pimatic.org/
GNU General Public License v2.0
7 stars 13 forks source link

Initial support for milight white bulbs #43

Open bjornhij opened 8 years ago

bjornhij commented 8 years ago

Color and brightness UI elements still there, but unusable.

bjornhij commented 8 years ago

See #42

philip1986 commented 8 years ago

Yeah, thx for contributing! @mwittig said here he will check the functionally, I just have those two minor objections I already mentioned before.

I will also check if we can do something about the UI for this type of bulbs.

mwittig commented 8 years ago

@philip1986 I don't think we should add a type property to the Milight device class as suggested by @bjornhij, but there should a new device class for this. Note, the contributed code does not handle dimming which works a lot different from RGBW dimming. With CW/WW LEDs the command set does not provide dimming value, but it provides commands to increase and decrease brightness. So, CW/WW need a UI class of its own.

philip1986 commented 8 years ago

@mwittig ok I got your point and I agree. I think for this bulbs the UI of dummy dimmer might be good enough.

bjornhij commented 8 years ago

I've created a new MilightCWWW class. Still figuring out how I can use another UI class.