Integration of Milight; Separation into device types

philip1986 / pimatic-led-light

A template for creating plugins

http://pimatic.org/

GNU General Public License v2.0

7 stars 13 forks source link

Integration of Milight; Separation into device types #5

Closed mwittig closed 9 years ago

mwittig commented 9 years ago

I have forked from master yesterday to integrate Milight. Pull request follows

mwittig commented 9 years ago

Just a few words about my code changes

I have created another device class "Milight" we uses the same template as LedLight
I have left the implementation of LedLight untouched, but you may want to consider the separation of Iwy and Wifi370 modes into two device classes. Note, you can also use inheritance as part of the device implementation, say a LedLightBase class for common functionality
As you can see I have split the plugin and device config into two files:
- led-light-schema.coffee defining plugin configuration properties (no properties, currently)
- device-config-schema.coffee defining device properties

mwittig commented 9 years ago

The following configuration works file for me

Plugin:

{
      "plugin": "led-light"
}

Device:

{
      "id": "led1",
      "class": "Milight",
      "name": "Milight",
      "addr": "192.168.178.64",
      "zone": 1,
      "location": "Kitchen",
      "device": "iwy-master"
},
{
      "id": "led2",
      "class": "LedLight",
      "name": "LED Light",
      "addr": "192.168.178.67",
      "location": "Bedroom",
      "device": "iwy-master"
}

philip1986 commented 9 years ago

checkout https://github.com/philip1986/pimatic-led-light/pull/7

philip1986 commented 9 years ago

Done by https://github.com/philip1986/pimatic-led-light/pull/9