search

philip1986 / pimatic-led-light

A template for creating plugins
http://pimatic.org/
GNU General Public License v2.0
7 stars 13 forks source link

Added priority config for Hyperion #60

Closed michbeck100 closed 8 years ago

michbeck100 commented 8 years ago

hyperion-client 1.0.3 added the possibility to set the used priority for calls against the hyperion device. This PR forwards this feature to the device config in pimatic.

mwittig commented 8 years ago

Thanks. I have seen that to but I have no detailed understanding of the hyperion library. Do you know what is exactly behind the priority parameter? Note the hyperion-client set priority to 1 if not set. Does this make sense?

I had a look at the hyperion project but I have only found info about priority for the framegrabbers

michbeck100 commented 8 years ago

I'm using the default value 100 because the command line utility of hyperion does this, too (see https://github.com/hyperion-project/hyperion/wiki/command-line-utility). As far as i know, the priority controls which calls to the device come first. This was a feature requested in https://forum.pimatic.org/topic/1098/implemented-hyperion-ambilight-json-control/4. Now that its possible with version 1.0.3 I followed this request ;-)

mwittig commented 8 years ago

OK, sounds reasonable. Thanks for the clarification and references!

mwittig commented 8 years ago

Cherry-picked manually into v0.9.x branch