search

philip1986 / pimatic-led-light

A template for creating plugins
http://pimatic.org/
GNU General Public License v2.0
7 stars 13 forks source link

Restore last state for power state #66

Closed michbeck100 closed 6 years ago

michbeck100 commented 7 years ago

This PR fixes the issue that pimatic-led-light cannot restore the last power state, when pimatic was restarted. To fix this i had to use boolean values for the power state throughout the complete plugin. This was mixed sometimes with strings. Furthermore was the last state not forwarded to the device classes.

michbeck100 commented 7 years ago

Oh, and this PR fixes the CI errors with Travis.

michbeck100 commented 7 years ago

@mwittig Did have the time to review my changes?

michbeck100 commented 7 years ago

@mwittig I've seen your last commit d5a81d1. This PR does the same but much more. It completely uses boolean values for the state. Furthermore it resolves this annoying bug that every light gets switched on when restarting pimatic using this plugin. It would be great if anyone could review the changes and hopefully merge and release them.

mwittig commented 7 years ago

I had issues with that. Did you test your changes with the frontend?

michbeck100 commented 7 years ago

Yes i did test successfully. Also the frontend. Maybe you have to clear the caches? I will test again, maybe some changes in the mean time broke it.

michbeck100 commented 7 years ago

@mwittig Can you tell what problems you had?

michbeck100 commented 7 years ago

I've merged the latest changes from 0.9.x and tested again. I had some issues but these were related to the caching of the frontend. Please try to clear caches and remove any precompiled js files.

michbeck100 commented 6 years ago

@mwittig will you release a new version of pimatic-led-light so i can finish https://github.com/michbeck100/pimatic-hap/issues/54?

mwittig commented 6 years ago

Will do, however, I am travelling right now up to end of next week with limited access to the computer/internet.

michbeck100 commented 6 years ago

Any updates on this?

michbeck100 commented 4 years ago

@mwittig back from traveling? 😁 will there be a new release?