search

philipdouglas / r2-d7

A bot for xwingtmg.slack.com
MIT License
13 stars 14 forks source link

Card Selection module #43

Closed Apollonaut13 closed 3 years ago

Apollonaut13 commented 3 years ago

Allows users to choose which card they want to see.

Example: https://i.gyazo.com/69c5ca0e44a27f323ac48436351847cd.mp4

danrs commented 3 years ago

@FreakyDug can you re-run the tests on this? It looks like it failed with a config error so I think just hitting rerun should make the tests go. I don't seem to have permission to hit that button (feel free to grant me permission on CircleCI if you like)

Apollonaut13 commented 3 years ago

@FreakyDug can you re-run the tests on this? It looks like it failed with a config error so I think just hitting rerun should make the tests go. I don't seem to have permission to hit that button (feel free to grant me permission on CircleCI if you like)

I can't run the tests on my machine, it requires too many modules that I don't have installed on the venv. I must have installed about 6 of them before reaching one that pip couldn't find for me. I updated the test files that have xwing wiki links on them, so hopefully it works now?

philipdouglas commented 3 years ago

@FreakyDug can you re-run the tests on this? It looks like it failed with a config error so I think just hitting rerun should make the tests go. I don't seem to have permission to hit that button (feel free to grant me permission on CircleCI if you like)

I think the problem is @Apollonaut13's fork doesn't have the circleCI config file. Merging from master on the main repo should fix that.

philipdouglas commented 3 years ago

@FreakyDug can you re-run the tests on this? It looks like it failed with a config error so I think just hitting rerun should make the tests go. I don't seem to have permission to hit that button (feel free to grant me permission on CircleCI if you like)

I can't run the tests on my machine, it requires too many modules that I don't have installed on the venv. I must have installed about 6 of them before reaching one that pip couldn't find for me. I updated the test files that have xwing wiki links on them, so hopefully it works now?

You should only need to install pytest in addition to what's in requirements.txt in order for the tests to run. What other modules is it looking for?

danrs commented 3 years ago

Also, you can log in to circleci with your git creds to see what goes wrong when you have pushed a build. Testing before pushing is ideal, but being able to see circle output is useful too

Apollonaut13 commented 3 years ago

I have no clue why it's giving so many errors. All the tests pass, but it can't seem to find the 'testbot' fixture for the cardlookup.

Apollonaut13 commented 3 years ago

@FreakyDug can you re-run the tests on this? It looks like it failed with a config error so I think just hitting rerun should make the tests go. I don't seem to have permission to hit that button (feel free to grant me permission on CircleCI if you like)

I can't run the tests on my machine, it requires too many modules that I don't have installed on the venv. I must have installed about 6 of them before reaching one that pip couldn't find for me. I updated the test files that have xwing wiki links on them, so hopefully it works now?

You should only need to install pytest in addition to what's in requirements.txt in order for the tests to run. What other modules is it looking for?

after installing slackclient, my PyCharm says there isn't a module called 'slackclient'