Closed philipjscott closed 5 years ago
@cmd430 Is it alright if I add you to the contributors section? :smiley:
Yeah no worries :)
EDIT:
also i messed around and allowed it to return the raw stream too (i just added a check for bool) but you could make it so if the output is not a string
or stream.Writable
(maybe just pass null
?) then return the raw stream
see: https://github.com/cmd430/simple-thumbnail/commit/f879026be0ec7ba873fdbc488ece57d686a6c7f0
also sorry about the shitty edits I was doing some experimenting for a project :P
:tada: This PR is included in version 1.4.0 :tada:
The release is available on:
Your semantic-release bot :package::rocket:
Context
There are situations where users may not want to save the thumbnails to disk, instead, they may want to pipe the image stream to a write stream (eg. S3, HTTP response, etc.).
Users will now be able to pass
Stream.Writable
as the output argument, eg.Objective
References
Lessons learned
pnpm
does not play nicely with ALE and Standard :sob: