search

philipjscott / simple-thumbnail

A library that produces thumbnails from images, videos and URLs :mag_right:
https://www.npmjs.com/package/simple-thumbnail
MIT License
25 stars 14 forks source link

Small error in documentation provided regarding to Ffmpeg path. #84

Open kaushikjatin opened 3 years ago

kaushikjatin commented 3 years ago

There is a section for those users who don't have Ffmpeg installed,, It is specified that those users can use 'Ffmpeg-static',, and a working example has been provided ,, which is here:

        const ffmpeg = require('ffmpeg-static')
        const genThumbnail = require('simple-thumbnail')
        async function download () {
          await genThumbnail('https://www.w3schools.com/Html/mov_bbb.webm', 'bunny.webm', '150x?', {
            path: ffmpeg.path
          })

          console.log('Done!')
        }

        download()

Problem -> path:ffmpeg.path Change needed -> path:ffmpeg

May be the ffmped-static have release a newer version and they have started providing path directly instead of providing it in side a javascript object as a property.