search

philipl / pidgin-indicator

AppIndicator/KStatusNotifierItem Plugin for Pidgin
GNU General Public License v2.0
39 stars 11 forks source link

Could the icon please show the current status? #6

Closed rrthomas closed 10 years ago

rrthomas commented 10 years ago

Pidgin's systray icon shows online status rather than a bird's head. Could the appindicator icon please do this too?

philipl commented 10 years ago

It does. The icons are loaded from DATADIR/pixmaps/pidgin/tray - just the same as the original systray icon. Assuming you're using the normal pidgin package, DATADIR is /usr/share. Remember to pass - -prefix=/usr to configure when building the indicator.

rrthomas commented 10 years ago

I did that, it doesn't work. I retried:

make uninstall make clean ./configure --prefix=/usr make && make install

Did I miss something?

rrthomas commented 10 years ago

I just tried checking out a fresh copy of git and redoing the above dance; still no luck. I have pidgin installed from my distro (Ubuntu), so --prefix=/usr should indeed be correct.

philipl commented 10 years ago

Do you have the icons in /usr/share/pixmaps/pidgin/tray?

Are you using an icon theme that doesn't inherit from hicolor?

rrthomas commented 10 years ago

Yes, I'm just using the stock Ubuntu build of Pidgin, and it stores its icons under /usr/share/pixmaps/pidgin/tray.

I'm using the "Gnome (default)" icon theme.

rrthomas commented 10 years ago

I tried changing my icon theme to specifically "Hicolor" and relaunching Pidgin; no joy.

rrthomas commented 10 years ago

I recompiled the plugin with a libpurple debug call in, so I can see it's trying to change the icon, but it just doesn't seem to be doing anything.

philipl commented 10 years ago

Are you using Unity? The Ubuntu System Settings -> Appearance section doesn't even let you choose hicolor or the default GNOME theme. If you're not using unity, then you shouldn't be using this indicator. Just use the normal systray icon (as every other desktop environment still supports it)

rrthomas commented 10 years ago

I'm using GNOME 3.10 with the appindicator shell extension. This works fine for Skype, Dropbox, ClipIt, Hamster Time Tracker &c.

rrthomas commented 10 years ago

(I'm also maintainer of Caffeine, which is another appindicator app, and that works fine, but it's written in Python against libappindicator 3)

philipl commented 10 years ago

Icon discovery is functionality provided by the appindicator widget in the desktop environment. The client side API lets me specify the location where the icons live but it's up to the widget to do anything with that information, and clearly the GNOME extension isn't doing anything sensible with it. Other apps can work fine if they integrate their icons into the main icon theme directories, but Pidgin doesn't do that.

You should use the systray icon.

rrthomas commented 10 years ago

Ah, OK. Thanks very much for your rapid and most helpful responses. Maybe a note in the documentation suggesting that appindicator support may not be enough for this extension to work is a good idea?

The reason I wanted to use it is that the GNOME 3 system tray is hidden off the bottom of the screen, and I was hoping to have an icon I could always see. Oh well.

philipl commented 10 years ago

If you're not opposed to manual work, you can copy/symlink the pidgin icons into the main hicolor theme directories - at that point, you should start seeing the right status icons.

rrthomas commented 10 years ago

Thanks!

rrthomas commented 10 years ago

This has now been fixed in the appindicator GNOME Shell extension.