philiplaureano
commented
11 years ago Hi Victor,
What does it say when you run PEVerify.exe on the modified assembly?
On Sun, May 26, 2013 at 3:42 AM, Drakulix notifications@github.com wrote:
First of all, thanks for this lovely framework. However I am having some issues using this framework, which are hopefully easy to fix and probably my own fault of miss-using this wonderful framework. I am quite an experienced Hobby-Programmer, however I have not worked too much with assembly code in general and found Mono.Cecil to be it quite difficult to use, if you want to achieve more complex results, besides adding some static method calls, so I was very happy that I found this on codeProject.com.
I am trying to inject some smaller code into an already compiled assembly, so I am using PostWeaver.exe. I tried weaving the complete assembly at the beginning, however that failed horribly with lots of exceptions, when running the resulting assembly, which was expected since the assembly is a really complex one, with lots of native library bindings. Which is why I started to weave only filtered method bodies and nothing else, but that should not be the problem, right?
I can modify methods returning void or objects quite well, however I run into problems when I want to edit a method returning a 'bool'. I have not tried to extend a wide range of methods, so I am not sure if this might also happen on other 'primitive' types.
The code of the to be modified assembly looks like this before weaving:
C#
private bool sendSilentRequest (string request){ if (this.m_Socket != null && this.m_Socket.Connected && this.IsServerInfoReceived ()) { if (!request.EndsWith ("\n")) { request += "\n"; } byte[] bytes = Encoding.get_UTF8 ().GetBytes (request); this.m_Socket.Send (bytes); return true; } return false;}
IL
.method private hidebysig instance bool sendSilentRequest ( string 'request' ) cil managed { // Method begins at RVA 0x31a50 // Code size 96 (0x60) .maxstack 14 .locals init ( [0] uint8[] )
IL_0000: ldarg.0 IL_0001: ldfld class [System]System.Net.Sockets.Socket Communicator::m_Socket IL_0006: brfalse IL_005e IL_000b: ldarg.0 IL_000c: ldfld class [System]System.Net.Sockets.Socket Communicator::m_Socket IL_0011: callvirt instance bool [System]System.Net.Sockets.Socket::get_Connected() IL_0016: brfalse IL_005e IL_001b: ldarg.0 IL_001c: call instance bool Communicator::IsServerInfoReceived() IL_0021: brfalse IL_005e IL_0026: ldarg.1 IL_0027: ldstr "\n" IL_002c: callvirt instance bool [mscorlib]System.String::EndsWith(string) IL_0031: brtrue IL_0043 IL_0036: ldarg.1 IL_0037: ldstr "\n" IL_003c: call string [mscorlib]System.String::Concat(string, string) IL_0041: starg.s 'request' IL_0043: call class [mscorlib]System.Text.Encoding [mscorlib]System.Text.Encoding::get_UTF8() IL_0048: ldarg.1 IL_0049: callvirt instance uint8[] [mscorlib]System.Text.Encoding::GetBytes(string) IL_004e: stloc.0 IL_004f: ldarg.0 IL_0050: ldfld class [System]System.Net.Sockets.Socket Communicator::m_Socket IL_0055: ldloc.0 IL_0056: callvirt instance int32 [System]System.Net.Sockets.Socket::Send(uint8[]) IL_005b: pop IL_005c: ldc.i4.1 IL_005d: ret IL_005e: ldc.i4.0 IL_005f: ret} // end of method
After Weaving it looks like this:
C#
private bool sendSilentRequest (string request){ bool isInterceptionDisabled; if (this is IModifiableType) { isInterceptionDisabled = (this as IModifiableType).IsInterceptionDisabled; } IInvocationInfo invocationInfo; IAroundInvokeProvider methodBodyReplacementProvider; IAroundInvoke surroundingImplementation; IAroundInvoke surroundingImplementation2; if (!isInterceptionDisabled) { Type[] typeArguments = new Type[0]; object[] arguments = new object[] { request }; MethodBase methodFromHandle = MethodBase.GetMethodFromHandle (methodof (Communicator.sendSilentRequest (string)).MethodHandle, typeof(Communicator).TypeHandle); invocationInfo = new InvocationInfo (this, methodFromHandle, new StackTrace (1, false), new Type[] { typeof(string) }, typeArguments, typeof(bool), arguments); IgnoredInstancesRegistry.AddInstance (invocationInfo); if (!isInterceptionDisabled) { IMethodReplacementProvider methodReplacementProvider = ((IMethodReplacementHost)this).MethodBodyReplacementProvider; if (this is IModifiableType && !isInterceptionDisabled) { methodBodyReplacementProvider = ((IMethodReplacementHost)this).MethodBodyReplacementProvider; methodReplacementProvider = ((IAroundInvokeHost)this).AroundMethodBodyProvider; if (methodReplacementProvider != null) { surroundingImplementation = methodReplacementProvider.GetSurroundingImplementation (invocationInfo); } surroundingImplementation2 = AroundMethodBodyRegistry.GetSurroundingImplementation (invocationInfo); if (surroundingImplementation2 != null) { surroundingImplementation2.BeforeInvoke (invocationInfo); } if (surroundingImplementation != null) { surroundingImplementation.BeforeInvoke (invocationInfo); } } } } IMethodReplacementProvider provider = MethodBodyReplacementProviderRegistry.GetProvider (this, invocationInfo); if (!isInterceptionDisabled) { if (methodBodyReplacementProvider != null || provider != null) { IInterceptor methodReplacement; if (methodBodyReplacementProvider != null) { methodReplacement = methodBodyReplacementProvider.GetMethodReplacement (this, invocationInfo); } if (methodReplacement == null) { if (provider != null) { methodReplacement = provider.GetMethodReplacement (this, invocationInfo); } } if (methodReplacement != null) { (bool)methodReplacement.Intercept (invocationInfo); goto IL_245; } } } if (this.m_Socket != null && this.m_Socket.Connected && this.IsServerInfoReceived ()) { if (!request.EndsWith ("\n")) { request += "\n"; } byte[] bytes = Encoding.UTF8.GetBytes (request); this.m_Socket.Send (bytes); 1; } else { 0; } IL_245: object obj; if (!isInterceptionDisabled) { if (surroundingImplementation == null) { } if (surroundingImplementation != null) { surroundingImplementation.AfterInvoke (invocationInfo, obj); } if (surroundingImplementation2 == null) { } if (surroundingImplementation2 != null) { surroundingImplementation2.AfterInvoke (invocationInfo, obj); } } return obj != null;}
IL
.method private hidebysig instance bool sendSilentRequest ( string 'request' ) cil managed { // Method begins at RVA 0x1c4a4 // Code size 671 (0x29f) .maxstack 7 .locals init ( [0] uint8[], [1] bool, [2] class LinFu.AOP.Interfaces.IInvocationInfo, [3] class LinFu.AOP.Interfaces.IAroundInvokeProvider, [4] class LinFu.AOP.Interfaces.IMethodReplacementProvider, [5] object, [6] class LinFu.AOP.Interfaces.IMethodReplacementProvider, [7] class [mscorlib]System.Reflection.MethodBase, [8] class [mscorlib]System.Type[], [9] object[], [10] class [mscorlib]System.Type[], [11] class LinFu.AOP.Interfaces.IAroundInvoke, [12] class LinFu.AOP.Interfaces.IAroundInvoke, [13] class LinFu.AOP.Interfaces.IInterceptor )
IL_0000: ldarg.0 IL_0001: isinst LinFu.AOP.Interfaces.IModifiableType IL_0006: brfalse IL_001a IL_000b: ldarg.0 IL_000c: isinst LinFu.AOP.Interfaces.IModifiableType IL_0011: callvirt instance bool LinFu.AOP.Interfaces.IModifiableType::get_IsInterceptionDisabled() IL_0016: stloc 1 IL_001a: nop IL_001b: ldloc 1 IL_001f: brtrue IL_014a IL_0024: ldc.i4 0 IL_0029: newarr [mscorlib]System.Type IL_002e: stloc 10 IL_0032: ldc.i4 1 IL_0037: newarr [mscorlib]System.Object IL_003c: stloc 9 IL_0040: ldloc 9 IL_0044: ldc.i4 0 IL_0049: ldarg 'request' IL_004d: stelem.ref IL_004e: ldarg.0 IL_004f: ldtoken method instance bool Communicator::sendSilentRequest(string) IL_0054: ldtoken Communicator IL_0059: call class [mscorlib]System.Reflection.MethodBase [mscorlib]System.Reflection.MethodBase::GetMethodFromHandle(valuetype [mscorlib]System.RuntimeMethodHandle, valuetype [mscorlib]System.RuntimeTypeHandle) IL_005e: stloc 7 IL_0062: ldloc 7 IL_0066: ldc.i4.1 IL_0067: ldc.i4.0 IL_0068: newobj instance void [mscorlib]System.Diagnostics.StackTrace::.ctor(int32, bool) IL_006d: ldc.i4 1 IL_0072: newarr [mscorlib]System.Type IL_0077: stloc 8 IL_007b: ldloc 8 IL_007f: ldc.i4 0 IL_0084: ldtoken [mscorlib]System.String IL_0089: call class [mscorlib]System.Type [mscorlib]System.Type::GetTypeFromHandle(valuetype [mscorlib]System.RuntimeTypeHandle) IL_008e: stelem.ref IL_008f: ldloc 8 IL_0093: ldloc 10 IL_0097: ldtoken [mscorlib]System.Boolean IL_009c: call class [mscorlib]System.Type [mscorlib]System.Type::GetTypeFromHandle(valuetype [mscorlib]System.RuntimeTypeHandle) IL_00a1: ldloc 9 IL_00a5: newobj instance void LinFu.AOP.Cecil.InvocationInfo::.ctor(object, class [mscorlib]System.Reflection.MethodBase, class [mscorlib]System.Diagnostics.StackTrace, class [mscorlib]System.Type[], class [mscorlib]System.Type[], class [mscorlib]System.Type, object[]) IL_00aa: stloc 2 IL_00ae: ldloc 2 IL_00b2: call void LinFu.AOP.Cecil.IgnoredInstancesRegistry::AddInstance(object) IL_00b7: ldloc 1 IL_00bb: brtrue IL_0149 IL_00c0: ldarg.0 IL_00c1: callvirt instance class LinFu.AOP.Interfaces.IMethodReplacementProvider LinFu.AOP.Interfaces.IMethodReplacementHost::get_MethodBodyReplacementProvider() IL_00c6: stloc 4 IL_00ca: ldarg.0 IL_00cb: isinst LinFu.AOP.Interfaces.IModifiableType IL_00d0: brfalse IL_0148 IL_00d5: ldloc 1 IL_00d9: brtrue IL_0148 IL_00de: ldarg.0 IL_00df: callvirt instance class LinFu.AOP.Interfaces.IMethodReplacementProvider LinFu.AOP.Interfaces.IMethodReplacementHost::get_MethodBodyReplacementProvider() IL_00e4: stloc 3 IL_00e8: ldarg.0 IL_00e9: callvirt instance class LinFu.AOP.Interfaces.IAroundInvokeProvider LinFu.AOP.Interfaces.IAroundInvokeHost::get_AroundMethodBodyProvider() IL_00ee: stloc 4 IL_00f2: ldloc 4 IL_00f6: brfalse IL_010c IL_00fb: ldloc 4 IL_00ff: ldloc 2 IL_0103: callvirt instance class LinFu.AOP.Interfaces.IAroundInvoke LinFu.AOP.Interfaces.IAroundInvokeProvider::GetSurroundingImplementation(class LinFu.AOP.Interfaces.IInvocationInfo) IL_0108: stloc 11 IL_010c: nop IL_010d: ldloc 2 IL_0111: call class LinFu.AOP.Interfaces.IAroundInvoke LinFu.AOP.Interfaces.AroundMethodBodyRegistry::GetSurroundingImplementation(class LinFu.AOP.Interfaces.IInvocationInfo) IL_0116: stloc 12 IL_011a: ldloc 12 IL_011e: brfalse IL_0130 IL_0123: ldloc 12 IL_0127: ldloc 2 IL_012b: callvirt instance void LinFu.AOP.Interfaces.IBeforeInvoke::BeforeInvoke(class LinFu.AOP.Interfaces.IInvocationInfo) IL_0130: nop IL_0131: ldloc 11 IL_0135: brfalse IL_0147 IL_013a: ldloc 11 IL_013e: ldloc 2 IL_0142: callvirt instance void LinFu.AOP.Interfaces.IBeforeInvoke::BeforeInvoke(class LinFu.AOP.Interfaces.IInvocationInfo) IL_0147: nop IL_0148: nop IL_0149: nop IL_014a: nop IL_014b: ldarg.0 IL_014c: ldloc 2 IL_0150: call class LinFu.AOP.Interfaces.IMethodReplacementProvider LinFu.AOP.Interfaces.MethodBodyReplacementProviderRegistry::GetProvider(object, class LinFu.AOP.Interfaces.IInvocationInfo) IL_0155: stloc 6 IL_0159: ldloc 1 IL_015d: brtrue IL_01dc IL_0162: ldloc 3 IL_0166: brtrue IL_0179 IL_016b: ldloc 6 IL_016f: brtrue IL_0179 IL_0174: br IL_01dc IL_0179: nop IL_017a: ldloc 3 IL_017e: brfalse IL_0195 IL_0183: ldloc 3 IL_0187: ldarg.0 IL_0188: ldloc 2 IL_018c: callvirt instance class LinFu.AOP.Interfaces.IInterceptor LinFu.AOP.Interfaces.IMethodReplacementProvider::GetMethodReplacement(object, class LinFu.AOP.Interfaces.IInvocationInfo) IL_0191: stloc 13 IL_0195: nop IL_0196: ldloc 13 IL_019a: brtrue IL_01bb IL_019f: ldloc 6 IL_01a3: brfalse IL_01ba IL_01a8: ldloc 6 IL_01ac: ldarg.0 IL_01ad: ldloc 2 IL_01b1: callvirt instance class LinFu.AOP.Interfaces.IInterceptor LinFu.AOP.Interfaces.IMethodReplacementProvider::GetMethodReplacement(object, class LinFu.AOP.Interfaces.IInvocationInfo) IL_01b6: stloc 13 IL_01ba: nop IL_01bb: nop IL_01bc: ldloc 13 IL_01c0: brfalse IL_01dc IL_01c5: ldloc 13 IL_01c9: ldloc 2 IL_01cd: callvirt instance object LinFu.AOP.Interfaces.IInterceptor::Intercept(class LinFu.AOP.Interfaces.IInvocationInfo) IL_01d2: unbox.any [mscorlib]System.Boolean IL_01d7: br IL_0245 IL_01dc: nop IL_01dd: ldarg.0 IL_01de: ldfld class [System]System.Net.Sockets.Socket Communicator::m_Socket IL_01e3: brfalse IL_023f IL_01e8: ldarg.0 IL_01e9: ldfld class [System]System.Net.Sockets.Socket Communicator::m_Socket IL_01ee: callvirt instance bool [System]System.Net.Sockets.Socket::get_Connected() IL_01f3: brfalse IL_023f IL_01f8: ldarg.0 IL_01f9: call instance bool Communicator::IsServerInfoReceived() IL_01fe: brfalse IL_023f IL_0203: ldarg.1 IL_0204: ldstr "\n" IL_0209: callvirt instance bool [mscorlib]System.String::EndsWith(string) IL_020e: brtrue IL_0220 IL_0213: ldarg.1 IL_0214: ldstr "\n" IL_0219: call string [mscorlib]System.String::Concat(string, string) IL_021e: starg.s 'request' IL_0220: call class [mscorlib]System.Text.Encoding [mscorlib]System.Text.Encoding::get_UTF8() IL_0225: ldarg.1 IL_0226: callvirt instance uint8[] [mscorlib]System.Text.Encoding::GetBytes(string) IL_022b: stloc.0 IL_022c: ldarg.0 IL_022d: ldfld class [System]System.Net.Sockets.Socket Communicator::m_Socket IL_0232: ldloc.0 IL_0233: callvirt instance int32 [System]System.Net.Sockets.Socket::Send(uint8[]) IL_0238: pop IL_0239: ldc.i4.1 IL_023a: br IL_0240 IL_023f: ldc.i4.0 IL_0240: br IL_0245 IL_0245: nop IL_0246: ldloc 1 IL_024a: brtrue IL_0299 IL_024f: ldloc 11 IL_0253: brtrue IL_0258 IL_0258: nop IL_0259: ldloc 11 IL_025d: brfalse IL_0273 IL_0262: ldloc 11 IL_0266: ldloc 2 IL_026a: ldloc 5 IL_026e: callvirt instance void LinFu.AOP.Interfaces.IAfterInvoke::AfterInvoke(class LinFu.AOP.Interfaces.IInvocationInfo, object) IL_0273: nop IL_0274: ldloc 12 IL_0278: brtrue IL_027d IL_027d: nop IL_027e: ldloc 12 IL_0282: brfalse IL_0298 IL_0287: ldloc 12 IL_028b: ldloc 2 IL_028f: ldloc 5 IL_0293: callvirt instance void LinFu.AOP.Interfaces.IAfterInvoke::AfterInvoke(class LinFu.AOP.Interfaces.IInvocationInfo, object) IL_0298: nop IL_0299: nop IL_029a: ldloc 5 IL_029e: ret} // end of method
The exception I get on runtime looks like this:
ERROR connecting new socket: System.InvalidProgramException: Invalid IL code in Communicator:sendSilentRequest (string): IL_029e: ret at Communicator.sendSilentRequest (.Message msg) [0x00000] in
:0 at Communicator.sendPing () [0x00000] in :0 at Communicator.makeConnection (System.String ip, Int32 port) [0x00000] in :0 I do not really depend on modifying this specific function and may work-around this somehow, however it would be much nicer this way and I do not want to run into this error on methods as well, especially, if it should be my own fault.
Greetings, looking forward to some answers, Victor Brekenfeld
Reply to this email directly or view it on GitHubhttps://github.com/philiplaureano/LinFu/issues/23 .
Drakulix
First of all, thanks for this lovely framework. However I am having some issues using this framework, which are hopefully easy to fix and probably my own fault of miss-using this wonderful framework. I am quite an experienced Hobby-Programmer, however I have not worked too much with assembly code in general and found Mono.Cecil to be it quite difficult to use, if you want to achieve more complex results, besides adding some static method calls, so I was very happy that I found this on codeProject.com.
I am trying to inject some smaller code into an already compiled assembly, so I am using PostWeaver.exe. I tried weaving the complete assembly at the beginning, however that failed horribly with lots of exceptions, when running the resulting assembly, which was expected since the assembly is a really complex one, with lots of native library bindings. Which is why I started to weave only filtered method bodies and nothing else, but that should not be the problem, right?
I can modify methods returning void or objects quite well, however I run into problems when I want to edit a method returning a 'bool'. I have not tried to extend a wide range of methods, so I am not sure if this might also happen on other 'primitive' types.
The code of the to be modified assembly looks like this before weaving:
C#
IL
After Weaving it looks like this:
C#
IL
The exception I get on runtime looks like this:
I do not really depend on modifying this specific function and may work-around this somehow, however it would be much nicer this way and I do not want to run into this error on methods as well, especially, if it should be my own fault.
Greetings, looking forward to some answers, Victor Brekenfeld