philiplb / CRUDlex

CRUDlex is an easy to use CRUD generator for Symfony 4 and Silex 2 which is great for auto generated admin pages
https://philiplb.de/crudlex/
MIT License
109 stars 23 forks source link

0.9.9 broken with silex/web-profiler ^1.0 #41

Closed germain-italic closed 8 years ago

germain-italic commented 8 years ago

First of all your congratulations for putting up CRUDlex!

CRUDlexSample deploys v.0.9.7 of ou the box. Adding Web Profiler works well also:

    "require": {
        "philiplb/crudlex": "0.9.7",
        "silex/web-profiler": "^1.0"
    }

Unfortunately upgrading to v0.9.9 conflicts with the Web Profiler:

Twig_Error_Syntax in ExpressionParser.php line 604:
Unknown "trans" filter in "@crud/list.twig" at line 22.

Downgrade to v0.9.8:

Twig_Error_Syntax in ExpressionParser.php line 604:
Unknown "trans" filter in "@crud/list.twig" at line 14.

Removing silex/web-profiler (v1.0.8) restores CRUDlex v0.9.8 - v0.9.9

Any hints?

philiplb commented 8 years ago

Will investigate and update the sample project.

philiplb commented 8 years ago

For now, I updated the sample project. It contains now tags for 0.9.7, 0.9.8, 0.9.9 and 0.9.x-dev (master): https://github.com/philiplb/CRUDlexSample/releases

germain-italic commented 8 years ago

Cool, but breaks compatibility with CRUDlexUser

ContextErrorException in CRUDUserSetup.php line 57:
Catchable Fatal Error: Argument 1 passed to CRUDlex\CRUDUserSetup::addEvents() must be an instance of CRUDlex\CRUDData, instance of CRUDlex\MySQLData given
philiplb commented 8 years ago

That's true. All dependend projects will get their tags and updates.

philiplb commented 8 years ago

Made it work by registering the in advance TranslationServiceProvider:

$app->register(new \Silex\Provider\TranslationServiceProvider(), array(
    'locale_fallbacks' => array('en'),
));

See this now added hint: http://philiplb.github.io/CRUDlex/docs/html/0.9.10/manual/extendedfeatures.html#combine-with-the-web-profiler

germain-italic commented 8 years ago

:+1:

This project gets more exciting each day!

philiplb commented 8 years ago

Glad you like it. :-)

philiplb commented 8 years ago

@ashorlivs Updated CRUDlexUser to the versioning scheme

germain-italic commented 8 years ago

Can't test in my project at the moment because I'm on the stable version, but seems OK @ dev.