Remove filters and listfields from description example - Githubissues

philiplb / CRUDlex

CRUDlex is an easy to use CRUD generator for Symfony 4 and Silex 2 which is great for auto generated admin pages

https://philiplb.de/crudlex/

MIT License

109 stars 23 forks source link

Remove filters and listfields from description example #82

Closed dmaciel closed 7 years ago

dmaciel commented 7 years ago

In the description feature example (first feature explained in Extended Features) are also other features that are explained later. At first sight is confusing to concentrate in the new feature example because the other two are above the new one, so it forces to read again the text.

coveralls commented 7 years ago

Coverage remained the same at 100.0% when pulling dc6eaa15ac0dc9b6994be42702bab7c0c3bf8f46 on dmaciel:master into 97569c2f18f4873d0adbe988b502b918e6f66400 on philiplb:master.

coveralls commented 7 years ago

Coverage remained the same at 100.0% when pulling dc6eaa15ac0dc9b6994be42702bab7c0c3bf8f46 on dmaciel:master into 97569c2f18f4873d0adbe988b502b918e6f66400 on philiplb:master.

coveralls commented 7 years ago

Coverage remained the same at 100.0% when pulling dc6eaa15ac0dc9b6994be42702bab7c0c3bf8f46 on dmaciel:master into 97569c2f18f4873d0adbe988b502b918e6f66400 on philiplb:master.

coveralls commented 7 years ago

Coverage remained the same at 100.0% when pulling dc6eaa15ac0dc9b6994be42702bab7c0c3bf8f46 on dmaciel:master into 97569c2f18f4873d0adbe988b502b918e6f66400 on philiplb:master.

coveralls commented 7 years ago

Coverage decreased (-96.09%) to 3.914% when pulling c97a7b960db9e414b2953012e2493a47f66bf1f0 on dmaciel:master into 97569c2f18f4873d0adbe988b502b918e6f66400 on philiplb:master.

coveralls commented 7 years ago

Coverage decreased (-0.3%) to 99.662% when pulling 8b08837ad7e930a91d7c859f2a57bc3756d716d1 on dmaciel:master into 97569c2f18f4873d0adbe988b502b918e6f66400 on philiplb:master.

dmaciel commented 7 years ago

I will close this pull request. The original intention was to update only the documentation. I had plans to create another pull request for a new feature, but it looks look like this new feature code is showing up in this pull request

philiplb commented 7 years ago

Hi, sorry, I was busy the last days. :) Looking forward for the PR. A small note to this one: The code then needs some unit testing and the API-docs need an update.

dmaciel commented 7 years ago

Hi Don't worry, the reason for closing the PR was that I want to make a first PR for the documentation (the original reason of this PR) but somehow the code that will be part of the new feature (that is lacking the tests) got inside this. I will make the new PR for separated as soon as possible. Thank you for your work