philiplb / CRUDlex

CRUDlex is an easy to use CRUD generator for Symfony 4 and Silex 2 which is great for auto generated admin pages
https://philiplb.de/crudlex/
MIT License
109 stars 23 forks source link

Add getFile to FileProcessor #90

Closed th-lange closed 7 years ago

philiplb commented 7 years ago

Hi, nice addition, thank you. A few points:

Midterm (Next week maybe? Depends on the time available), the FileProcessor interface will be replaced by the Flysystem library. Maybe it would be worthwile to wait for that?

philiplb commented 7 years ago

Flysystem also supports streams, so an integration of it is very likely: https://flysystem.thephpleague.com/api/

philiplb commented 7 years ago

As Flysystem is integrated now, this PR is obsolete. But nontheless, thanks again.